patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix build issue
Date: Tue, 06 Nov 2018 21:27:19 +0100	[thread overview]
Message-ID: <59314752.LC5aAjuh3R@xps> (raw)
In-Reply-To: <20181106133127.GA29301@jerin>

06/11/2018 14:31, Jerin Jacob:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 06/11/2018 12:45, Jerin Jacob:
> > > Some toolchain has fls() definition in string.h as argument type int,
> > > which is conflicting uint32_t argument type.
> > >
> > > /export/dpdk.org/lib/librte_eal/common/rte_reciprocal.c:47:19:
> > > error: conflicting types for ‘fls’
> > >  static inline int fls(uint32_t x)
> > >                   ^~~
> > >
> > > /opt/marvell-tools-201/aarch64-marvell-elf/include/strings.h:59:6:
> > > note: previous declaration of ‘fls’ was here
> > >  int  fls(int) __pure2;
> > >
> > > FreeBSD string.h also has fls() with argument as int type.
> > > https://www.freebsd.org/cgi/man.cgi?query=fls&sektion=3
> > >
> > > Fixing the conflict by renaming internal function as __fls
> > 
> > Why not rte_fls? Would it be more future proof?
> 
> Agreed. There are two instance of fls in dpdk code base now,
> 
> 1) lib/librte_eal/common/rte_reciprocal.c takes uint32_t
> 2) drivers/net/fm10k/fm10k_ethdev.c has macro, used with uint16_t as
> argument.
> 
> Should we make it as macro or follow libc prototype where argument is
> int.
> 
> Something like below,
> 
> static inline int
> rte_fls(int x)
> {
> 	return (x == 0) ? 0 : sizeof(x) * 8 - __builtin_clz(x);
> }

I tend to think that using uint32_t parameter would be more useful in DPDK.

  reply	other threads:[~2018-11-06 20:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 11:45 Jerin Jacob
2018-11-06 12:29 ` Thomas Monjalon
2018-11-06 13:31   ` Jerin Jacob
2018-11-06 20:27     ` Thomas Monjalon [this message]
     [not found] ` <20181107065833.16756-1-jerin.jacob@caviumnetworks.com>
2018-11-07  6:59   ` [dpdk-stable] [dpdk-dev] [PATCH v2 2/2] " Jerin Jacob
2018-11-12  1:37     ` Thomas Monjalon
2018-11-12  4:50       ` Jerin Jacob
2018-11-12  9:01         ` Ferruh Yigit
2018-11-12  9:17           ` Thomas Monjalon
2018-11-12 12:28     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59314752.LC5aAjuh3R@xps \
    --to=thomas@monjalon.net \
    --cc=Jerin.JacobKollanukkaran@cavium.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).