From: Thomas Monjalon <thomas@monjalon.net>
To: Ray Kinsella <mdr@ashroe.eu>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Kalesh A P <kalesh-anakkur.purayil@broadcom.com>,
dev@dpdk.org, ajit.khaparde@broadcom.com, asafp@nvidia.com,
David Marchand <david.marchand@redhat.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events
Date: Tue, 15 Feb 2022 16:12:29 +0100 [thread overview]
Message-ID: <5940456.YiXZdWvhHV@thomas> (raw)
In-Reply-To: <87zgmsgrp8.fsf@mdr78.vserver.site>
15/02/2022 14:55, Ray Kinsella:
> Ray Kinsella <mdr@ashroe.eu> writes:
> > Thomas Monjalon <thomas@monjalon.net> writes:
> >> 14/02/2022 17:06, Ray Kinsella:
> >>> Thomas Monjalon <thomas@monjalon.net> writes:
> >>> > 14/02/2022 11:16, Ray Kinsella:
> >>> >> Ray Kinsella <mdr@ashroe.eu> writes:
> >>> >> > Thomas Monjalon <thomas@monjalon.net> writes:
> >>> >> >> We never know how this enum will be used by the application.
> >>> >> >> The max value may be used for the size of an event array.
> >>> >> >> It looks a real ABI issue unfortunately.
> >>> >> >
> >>> >> > Right - but we only really care about it when an array size based on MAX
> >>> >> > is likely to be passed to DPDK, which doesn't apply in this case.
> >>> >
> >>> > I don't completely agree.
> >>> > A developer may assume an event will never exceed MAX value.
> >>> > However, after an upgrade of DPDK without app rebuild,
> >>> > a higher event value may be received in the app,
> >>> > breaking the assumption.
> >>> > Should we consider this case as an ABI breakage?
> >>>
> >>> Nope - I think we should explicitly exclude MAX values from any
> >>> ABI guarantee, as being able to change them is key to our be able to
> >>> evolve DPDK while maintaining ABI stability.
> >>
> >> Or we can simply remove the MAX values so there is no confusion.
> >>
> >>> Consider what it means applying the ABI policy to a MAX value, you are
> >>> in effect saying that that no value can be added to this enumeration
> >>> until the next ABI version, for me this is very restrictive without a
> >>> solid reason.
> >>
> >> I agree it is too much restrictive, that's why I am advocating
> >> for their removal.
> >
> > I think that would be simplest yes - may require some rework of the
> > sample code though. I will take a look at it.
>
> Thinking about this some more - we can't remove the MAX values between
> now the next stable ABI. So we may need a short term plan, and long term
> plan.
>
> Long term, I agree we look at every _MAX enumeration value and ask do we
> need it.
>
> Short term (until the next ABI), we still need to answer the question do
> we allow people to change _MAX values?
There's a problem of incentive.
We already said in the past that we should remove the _MAX values,
but it doesn't happen because our time on this planet is limited.
I think it would work if the developers have a special interest in such work.
And guess what? Here there is a special interest to remove this one.
If we are at the negotiation table, we could imagine a short-term exception
if the long-term patch is available and reviewed.
next prev parent reply other threads:[~2022-02-15 15:12 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 10:16 [dpdk-dev] [RFC PATCH 0/3] librte_ethdev: error recovery support Kalesh A P
2020-01-22 10:16 ` [dpdk-dev] [RFC PATCH 1/3] librte_ethdev: support device recovery event Kalesh A P
2020-03-11 13:20 ` Thomas Monjalon
2020-03-12 3:31 ` Kalesh Anakkur Purayil
2020-03-12 7:29 ` Thomas Monjalon
2020-01-22 10:16 ` [dpdk-dev] [RFC PATCH 2/3] net/bnxt: notify applications about device reset Kalesh A P
2020-01-22 10:16 ` [dpdk-dev] [RFC PATCH 3/3] app/testpmd: handle device recovery event Kalesh A P
2020-03-11 13:19 ` [dpdk-dev] [RFC PATCH 0/3] librte_ethdev: error recovery support Thomas Monjalon
2020-03-12 3:25 ` Kalesh Anakkur Purayil
2020-03-12 7:34 ` Thomas Monjalon
2020-07-03 16:12 ` Ferruh Yigit
2020-09-30 7:03 ` [dpdk-dev] [RFC V2 " Kalesh A P
2020-09-30 7:03 ` [dpdk-dev] [RFC V2 1/3] ethdev: support device reset and recovery events Kalesh A P
2020-09-30 7:03 ` [dpdk-dev] [RFC V2 2/3] net/bnxt: notify applications about device reset/recovery Kalesh A P
2020-09-30 7:03 ` [dpdk-dev] [RFC V2 3/3] app/testpmd: handle device recovery event Kalesh A P
2020-09-30 7:07 ` [dpdk-dev] [RFC PATCH v2 0/3] librte_ethdev: error recovery support Kalesh A P
2020-09-30 7:07 ` [dpdk-dev] [RFC PATCH v2 1/3] ethdev: support device reset and recovery events Kalesh A P
2020-09-30 7:07 ` [dpdk-dev] [RFC PATCH v2 2/3] net/bnxt: notify applications about device reset/recovery Kalesh A P
2020-09-30 7:07 ` [dpdk-dev] [RFC PATCH v2 3/3] app/testpmd: handle device recovery event Kalesh A P
2020-09-30 7:12 ` [dpdk-dev] [RFC PATCH v3 0/3] librte_ethdev: error recovery support Kalesh A P
2020-09-30 7:12 ` [dpdk-dev] [RFC PATCH v3 1/3] ethdev: support device reset and recovery events Kalesh A P
2020-09-30 7:50 ` Thomas Monjalon
2020-09-30 8:35 ` Kalesh Anakkur Purayil
2020-09-30 9:31 ` Thomas Monjalon
2020-09-30 7:12 ` [dpdk-dev] [RFC PATCH v3 2/3] net/bnxt: notify applications about device reset/recovery Kalesh A P
2020-09-30 7:12 ` [dpdk-dev] [RFC PATCH v3 3/3] app/testpmd: handle device recovery event Kalesh A P
2020-10-08 10:53 ` Asaf Penso
2020-09-30 12:33 ` [dpdk-dev] [RFC PATCH v4 0/3] librte_ethdev: error recovery support Kalesh A P
2020-09-30 12:33 ` [dpdk-dev] [RFC PATCH v4 1/3] ethdev: support device reset and recovery events Kalesh A P
2020-09-30 12:33 ` [dpdk-dev] [RFC PATCH v4 2/3] net/bnxt: notify applications about device reset/recovery Kalesh A P
2020-09-30 12:33 ` [dpdk-dev] [RFC PATCH v4 3/3] app/testpmd: handle device recovery event Kalesh A P
2020-10-06 17:25 ` Ophir Munk
2020-10-07 4:46 ` Kalesh Anakkur Purayil
2020-10-07 8:36 ` Ophir Munk
2020-10-07 9:37 ` Ferruh Yigit
2020-10-07 18:42 ` Ajit Khaparde
2020-10-07 16:49 ` [dpdk-dev] [PATCH v5 0/3] librte_ethdev: error recovery support Kalesh A P
2020-10-07 16:49 ` [dpdk-dev] [PATCH v5 1/3] ethdev: support device reset and recovery events Kalesh A P
2020-10-08 10:49 ` Asaf Penso
2020-10-07 16:49 ` [dpdk-dev] [PATCH v5 2/3] net/bnxt: notify applications about device reset/recovery Kalesh A P
2020-10-07 16:49 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: handle device recovery event Kalesh A P
2020-10-09 3:48 ` [dpdk-dev] [PATCH v6 0/3] librte_ethdev: error recovery support Kalesh A P
2020-10-09 3:48 ` [dpdk-dev] [PATCH v6 1/3] ethdev: support device reset and recovery events Kalesh A P
2020-10-11 21:29 ` Thomas Monjalon
2020-10-12 8:09 ` Andrew Rybchenko
2021-02-18 15:32 ` Ferruh Yigit
2020-10-09 3:48 ` [dpdk-dev] [PATCH v6 2/3] net/bnxt: notify applications about device reset/recovery Kalesh A P
2020-10-09 3:48 ` [dpdk-dev] [PATCH v6 3/3] app/testpmd: handle device recovery event Kalesh A P
2022-01-28 12:48 ` [dpdk-dev] [PATCH v7 0/4] ethdev: error recovery support Kalesh A P
2022-01-28 12:48 ` [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events Kalesh A P
2022-02-01 12:11 ` Ferruh Yigit
2022-02-01 13:09 ` Kalesh Anakkur Purayil
2022-02-01 13:19 ` Ferruh Yigit
2022-02-03 20:28 ` Ajit Khaparde
2022-02-10 22:42 ` Thomas Monjalon
2022-02-01 12:52 ` Ferruh Yigit
2022-02-02 11:44 ` Ray Kinsella
2022-02-10 22:16 ` Thomas Monjalon
2022-02-11 10:09 ` Ray Kinsella
2022-02-14 10:16 ` Ray Kinsella
2022-02-14 11:15 ` Thomas Monjalon
2022-02-14 16:06 ` Ray Kinsella
2022-02-14 16:25 ` Thomas Monjalon
2022-02-14 18:27 ` Ray Kinsella
2022-02-15 13:55 ` Ray Kinsella
2022-02-15 15:12 ` Thomas Monjalon [this message]
2022-02-15 16:12 ` Ray Kinsella
2022-05-21 10:33 ` fengchengwen
2022-05-24 15:11 ` Ray Kinsella
2022-06-10 0:16 ` fengchengwen
2022-01-28 12:48 ` [dpdk-dev] [PATCH v7 2/4] app/testpmd: handle device recovery event Kalesh A P
2022-01-28 12:48 ` [dpdk-dev] [PATCH v7 3/4] net/bnxt: notify applications about device reset/recovery Kalesh A P
2022-01-28 12:48 ` [dpdk-dev] [PATCH v7 4/4] doc: update release notes Kalesh A P
2022-02-01 12:12 ` Ferruh Yigit
2022-06-16 9:41 ` [PATCH v8 0/4] ethdev: support error recovery notification Chengwen Feng
2022-06-16 9:41 ` [PATCH v8 1/4] ethdev: support device " Chengwen Feng
2022-06-20 17:42 ` Thomas Monjalon
2022-06-21 1:38 ` fengchengwen
2022-06-21 7:04 ` Thomas Monjalon
2022-09-22 7:53 ` fengchengwen
2022-06-23 15:58 ` Ray Kinsella
2022-06-16 9:41 ` [PATCH v8 2/4] app/testpmd: handle error recovery notification event Chengwen Feng
2022-06-16 9:41 ` [PATCH v8 3/4] net/hns3: support " Chengwen Feng
2022-06-16 9:41 ` [PATCH v8 4/4] net/bnxt: notify applications about device reset/recovery Chengwen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5940456.YiXZdWvhHV@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=asafp@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=mdr@ashroe.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).