From: "Pei, Andy" <andy.pei@intel.com>
To: "Xu, Rosen" <rosen.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Kovacevic, Marko" <marko.kovacevic@intel.com>,
"liq3ea@163.com" <liq3ea@163.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr
Date: Wed, 17 Apr 2019 07:17:54 +0000 [thread overview]
Message-ID: <5941F446C088714A85408FA3132CFCBB010091CC@SHSMSX105.ccr.corp.intel.com> (raw)
In-Reply-To: <0E78D399C70DA940A335608C6ED296D73A6B81CB@SHSMSX104.ccr.corp.intel.com>
Okay
-----Original Message-----
From: Xu, Rosen
Sent: Wednesday, April 17, 2019 3:14 PM
To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org
Cc: Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com; stable@dpdk.org
Subject: RE: [PATCH] raw/ifpga: fix fd leak in rte fpga do pr
Hi,
> -----Original Message-----
> From: Pei, Andy
> Sent: Wednesday, April 17, 2019 14:49
> To: dev@dpdk.org
> Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>;
> Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com;
> stable@dpdk.org
> Subject: [PATCH] raw/ifpga: fix fd leak in rte fpga do pr
Pls use raw/ifpga_rawdev prefix.
I suggest you to run ./devtools/check-git-log.sh -1 before you sending patch.
> In rte_fpga_do_pr() function, if 'stat' returns error,
> rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that
> has been opened.
> After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns
> -EINVAL when 'stat' returns error
Pls put this in the commit message:
Coverity issue: 279441
> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> Cc: rosen.xu@intel.com
> Cc: marko.kovacevic@intel.com
> Cc: liq3ea@163.com
> Cc: andy.pei@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> ---
> drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> index da772d0..eff001b 100644
> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> @@ -244,7 +244,8 @@
> if (ret) {
> IFPGA_RAWDEV_PMD_ERR("stat on bitstream file
> failed: %s\n",
> file_name);
> - return -EINVAL;
> + ret = -EINVAL;
> + goto close_fd;
> }
> buffer_size = file_stat.st_size;
> IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);
> --
> 1.8.3.1
next prev parent reply other threads:[~2019-04-17 7:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 6:49 Andy Pei
2019-04-17 7:14 ` Xu, Rosen
2019-04-17 7:17 ` Pei, Andy [this message]
2019-04-17 7:16 ` [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: " Andy Pei
2019-04-17 8:03 ` Xu, Rosen
2019-04-22 17:52 ` Thomas Monjalon
2019-04-23 1:19 ` Pei, Andy
2019-04-23 1:36 ` Xu, Rosen
2019-04-23 8:45 ` Thomas Monjalon
2019-04-24 1:13 ` Pei, Andy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5941F446C088714A85408FA3132CFCBB010091CC@SHSMSX105.ccr.corp.intel.com \
--to=andy.pei@intel.com \
--cc=dev@dpdk.org \
--cc=liq3ea@163.com \
--cc=marko.kovacevic@intel.com \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).