From: Thomas Monjalon <thomas@monjalon.net>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/ethtool: remove redundant assignment
Date: Wed, 21 Apr 2021 20:27:06 +0200 [thread overview]
Message-ID: <5999123.3RDrOkptSD@thomas> (raw)
In-Reply-To: <1618972783-22453-1-git-send-email-humin29@huawei.com>
21/04/2021 04:39, Min Hu (Connor):
> From: Chengwen Feng <fengchengwen@huawei.com>
>
> The new_mtu was assigned twice, the first assignment could be removed.
>
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> - new_mtu = atoi(params->opt);
> new_mtu = strtoul(params->opt, &ptr_parse_end, 10);
Indeed, it looks useless.
Applied, thanks.
prev parent reply other threads:[~2021-04-21 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 2:39 Min Hu (Connor)
2021-04-21 18:27 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5999123.3RDrOkptSD@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).