From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: "Wiles, Roger Keith (Wind River)" <keith.wiles@windriver.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] Adding the routines rte_pktmbuf_alloc_bulk() and rte_pktmbuf_free_bulk()
Date: Tue, 7 Oct 2014 08:06:30 +0000 [thread overview]
Message-ID: <59AF69C657FD0841A61C55336867B5B03441C3F7@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1412627168-78475-1-git-send-email-keith.wiles@windriver.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Keith Wiles
> Sent: Monday, October 06, 2014 9:26 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] Adding the routines rte_pktmbuf_alloc_bulk()
> and rte_pktmbuf_free_bulk()
>
> Minor helper routines to mirror the mempool routines and remove the code
> from applications. The ixgbe_rxtx_vec.c routine could be changed to use
> the ret_pktmbuf_alloc_bulk() routine inplace of rte_mempool_get_bulk().
>
Can we maybe remove the reference to the vector driver for this patch. I don't believe changes there are what we want to do.
/Bruce
> Combined __rte_mbuf_raw_alloc_bulk into the rte_pktmbuf_alloc_bulk
> function.
> Fixed up the comments to state the correct return values.
>
> Signed-off-by: Keith Wiles <keith.wiles@windriver.com>
> ---
> lib/librte_mbuf/rte_mbuf.h | 55
> ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 55 insertions(+)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index 1c6e115..337611b 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -671,6 +671,44 @@ __rte_pktmbuf_prefree_seg(struct rte_mbuf *m)
> }
>
> /**
> + * Allocate a list of mbufs from a mempool into a mbuf array.
> + *
> + * This mbuf list contains one segment per mbuf, which has a length of 0. The
> pointer
> + * to data is initialized to have some bytes of headroom in the buffer
> + * (if buffer size allows).
> + *
> + * The routine is just a simple wrapper routine to reduce code in the application
> and
> + * provide a cleaner API for multiple mbuf requests.
> + *
> + * @param mp
> + * The mempool from which the mbuf is allocated.
> + * @param m_list
> + * An array of mbuf pointers, cnt must be less then or equal to the size of the
> array.
> + * @param cnt
> + * Number of slots in the m_list array to fill.
> + * @return
> + * - cnt is returned if a successful allocation.
> + * - <0 negative number is an error code.
> + */
> +static inline int __attribute__((always_inline))
> +rte_pktmbuf_alloc_bulk(struct rte_mempool *mp, struct rte_mbuf *m_list[],
> int16_t cnt)
> +{
> + int ret;
> +
> + ret = rte_mempool_get_bulk(mp, (void **)m_list, cnt);
> + if ( ret == 0 ) {
> + ret = cnt;
> + while(cnt--) {
> +#ifdef RTE_MBUF_REFCNT
> + rte_mbuf_refcnt_set(*m_list, 1);
> +#endif /* RTE_MBUF_REFCNT */
> + rte_pktmbuf_reset(*m_list++);
> + }
> + }
> + return ret;
> +}
> +
> +/**
> * Free a segment of a packet mbuf into its original mempool.
> *
> * Free an mbuf, without parsing other segments in case of chained
> @@ -708,6 +746,23 @@ static inline void rte_pktmbuf_free(struct rte_mbuf
> *m)
> }
> }
>
> +/**
> + * Free a list of packet mbufs back into its original mempool.
> + *
> + * Free a list of mbufs by calling rte_pktmbuf_free() in a loop as a wrapper
> function.
> + *
> + * @param m_list
> + * An array of rte_mbuf pointers to be freed.
> + * @param npkts
> + * Number of packets to free in m_list.
> + */
> +static inline void __attribute__((always_inline))
> +rte_pktmbuf_free_bulk(struct rte_mbuf *m_list[], int16_t npkts)
> +{
> + while(npkts--)
> + rte_pktmbuf_free(*m_list++);
> +}
> +
> #ifdef RTE_MBUF_REFCNT
>
> /**
> --
> 2.1.0
prev parent reply other threads:[~2014-10-07 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 20:26 Keith Wiles
2014-10-07 8:06 ` Richardson, Bruce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59AF69C657FD0841A61C55336867B5B03441C3F7@IRSMSX103.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).