From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Ilya Maximets <i.maximets@samsung.com>,
"Yang, Zhiyong" <zhiyong.yang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "yliu@fridaylinux.org" <yliu@fridaylinux.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] vhost: unlink existing file for server mode
Date: Fri, 2 Feb 2018 15:38:10 +0000 [thread overview]
Message-ID: <59AF69C657FD0841A61C55336867B5B0722435EE@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <8dda4863-b45a-7f71-1c2d-7df6e67b05b0@samsung.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ilya Maximets
> Sent: Friday, February 2, 2018 3:30 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org
> Cc: yliu@fridaylinux.org; maxime.coquelin@redhat.com
> Subject: Re: [dpdk-dev] vhost: unlink existing file for server mode
>
> Oh.
>
> It's such a game: twice a year someone sends this patch to mail list.
>
> I have another one for you:
> * Find all the patches equal to this one in archives.
> * Read all the discussions.
> * Come back if you have some new ideas, not already discussed many times
> here.
>
> Sorry for my sarcasm.
> NACK for this, as usual.
>
> Best regards, Ilya Maximets.
Surely the fact of repeated patches is an indication that this should be
explicitly called out at appropriately places in the code via comments.
Far easier to provide people the info in the code they are changing than
expecting them to trawl through historical mailing list entries.
Regards,
/Bruce
>
> On 02.02.2018 11:39, Zhiyong Yang wrote:
> > Vhost-user startup will fail based on server mode, if the specified
> > socket file has already existed. The patch introduces function
> > unlink() to remove the possible existing file.
> >
> > Cc: yliu@fridaylinux.org
> > Cc: maxime.coquelin@redhat.com
> >
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> > ---
> > lib/librte_vhost/socket.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> > index 6e3857e7a..324a24f4e 100644
> > --- a/lib/librte_vhost/socket.c
> > +++ b/lib/librte_vhost/socket.c
> > @@ -315,6 +315,7 @@ vhost_user_start_server(struct vhost_user_socket
> *vsocket)
> > int fd = vsocket->socket_fd;
> > const char *path = vsocket->path;
> >
> > + unlink(path);
> > ret = bind(fd, (struct sockaddr *)&vsocket->un, sizeof(vsocket-
> >un));
> > if (ret < 0) {
> > RTE_LOG(ERR, VHOST_CONFIG,
> >
next prev parent reply other threads:[~2018-02-02 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 8:39 [dpdk-dev] [PATCH] " Zhiyong Yang
[not found] ` <CGME20180202152959eucas1p29e4663da3740566114fdb82045ee3caf@eucas1p2.samsung.com>
2018-02-02 15:29 ` [dpdk-dev] " Ilya Maximets
2018-02-02 15:38 ` Richardson, Bruce [this message]
2018-02-02 15:47 ` Ilya Maximets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59AF69C657FD0841A61C55336867B5B0722435EE@IRSMSX103.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=maxime.coquelin@redhat.com \
--cc=yliu@fridaylinux.org \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).