From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: "luca.boccassi@gmail.com" <luca.boccassi@gmail.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Luca Boccassi <bluca@debian.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] igb_uio: pass MODULE_CFLAGS in new Kbuild
Date: Tue, 1 May 2018 13:44:19 +0000 [thread overview]
Message-ID: <59AF69C657FD0841A61C55336867B5B0723789AB@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20180501133907.15310-1-luca.boccassi@gmail.com>
> -----Original Message-----
> From: luca.boccassi@gmail.com [mailto:luca.boccassi@gmail.com]
> Sent: Tuesday, May 1, 2018 2:39 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Luca Boccassi
> <bluca@debian.org>; stable@dpdk.org
> Subject: [PATCH] igb_uio: pass MODULE_CFLAGS in new Kbuild
>
> From: Luca Boccassi <bluca@debian.org>
>
> With the legacy build system MODULE_CFLAGS can be set to pass compiler
> flags specific for the kernel modules builds.
> This is used currently by Ubuntu and Debian.
> Set ccflags-y in the Kbuild to achieve the same result with Meson, and to
> keep backward compatbility with older scripts.
>
> Fixes regression in Ubuntu/Debian when the Kbuild is included in the DKMS
> source package, as DKMS will pick it up silently by default if present,
> causing the MODULE_CFLAGS to be ignored.
>
> Fixes: a52f4574f798 ("igb_uio: build with meson")
> Cc: stable@dpdk.org
> ---
> kernel/linux/igb_uio/Kbuild | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/linux/igb_uio/Kbuild b/kernel/linux/igb_uio/Kbuild
> index 98c98fe52..3ab85c411 100644
> --- a/kernel/linux/igb_uio/Kbuild
> +++ b/kernel/linux/igb_uio/Kbuild
> @@ -1 +1,2 @@
> +ccflags-y := $(MODULE_CFLAGS)
> obj-m := igb_uio.o
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2018-05-01 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 13:39 luca.boccassi
2018-05-01 13:44 ` Richardson, Bruce [this message]
2018-05-01 13:50 ` [dpdk-stable] [PATCH v2] " luca.boccassi
2018-05-01 15:11 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59AF69C657FD0841A61C55336867B5B0723789AB@IRSMSX103.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=luca.boccassi@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).