From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Beilei Xing <beilei.xing@intel.com>, wenzhuo.lu@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: remove MTU setting limitation when port's stopped
Date: Wed, 5 Jul 2017 14:59:43 +0100 [thread overview]
Message-ID: <5a29e420-9692-670e-d3e4-f61c20c2a6b3@intel.com> (raw)
In-Reply-To: <1499222024-64581-1-git-send-email-beilei.xing@intel.com>
On 7/5/2017 3:33 AM, Beilei Xing wrote:
> Currently, setting MTU will fail if MTU requires the support
> of scattered packets before scatter is enabled.
> This patch allows setting this special MTU when device is
> stopped, cause scatter will be re-configured during starting
> port.
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
> v2 changes:
> - change commit log
>
> drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index fb5574e..ece5d6c 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -4812,6 +4812,7 @@ ixgbe_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
> struct rte_eth_dev_info dev_info;
> uint32_t frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN;
> struct rte_eth_rxmode *rx_conf = &dev->data->dev_conf.rxmode;
> + struct rte_eth_dev_data *dev_data = dev->data;
>
> ixgbe_dev_info_get(dev, &dev_info);
>
> @@ -4819,13 +4820,15 @@ ixgbe_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
> if ((mtu < ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))
> return -EINVAL;
>
> - /* refuse mtu that requires the support of scattered packets when this
> - * feature has not been enabled before.
> + /* If device is started, refuse mtu that requires the support of
> + * scattered packets when this feature has not been enabled before.
> */
> - if (!rx_conf->enable_scatter &&
> + if (dev_data->dev_started && !rx_conf->enable_scatter &&
Should dev->data->scattered_rx be used here?
rx_conf->enable_scatter is configuration value provided by user, but
dev->data->scattered_rx keeps the actual status of the feature.
Driver may decide to enable scattered rx even tough configuration didn't
asked for it, this behavior is what this patch relies on.
Can you confirm that there is no other case that can prevent enabling
scattered rx?
Otherwise this patch will let setting MTU bigger than mbuf and if
somehow scattered rx is not enabled, this may break the Rx path I guess.
> (frame_size + 2 * IXGBE_VLAN_TAG_SIZE >
> - dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM))
> + dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM)) {
> + PMD_INIT_LOG(ERR, "Stop port first.");
> return -EINVAL;
> + }
>
> hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> hlreg0 = IXGBE_READ_REG(hw, IXGBE_HLREG0);
>
next prev parent reply other threads:[~2017-07-05 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 8:22 [dpdk-dev] [PATCH] net/ixgbe: align setting MTU behavior with i40e Beilei Xing
2017-07-05 2:33 ` [dpdk-dev] [PATCH v2] net/ixgbe: remove MTU setting limitation when port's stopped Beilei Xing
2017-07-05 3:19 ` Lu, Wenzhuo
2017-07-05 13:59 ` Ferruh Yigit [this message]
2017-07-06 3:23 ` Xing, Beilei
2017-07-06 3:36 ` [dpdk-dev] [PATCH v3] " Beilei Xing
2017-07-06 9:49 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a29e420-9692-670e-d3e4-f61c20c2a6b3@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).