From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Cc: Ivan Malov <ivan.malov@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH] net/sfc: fix Tx reap behaviour on port stop on EF10 datapath
Date: Mon, 23 Oct 2017 11:08:43 -0700 [thread overview]
Message-ID: <5a35c104-6c8c-6b08-3a71-aa02a6142282@intel.com> (raw)
In-Reply-To: <1508319597-21039-1-git-send-email-arybchenko@solarflare.com>
On 10/18/2017 2:39 AM, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
>
> Tx reap mechanism on EF10 native datapath was altered by one
> of the recent patches to introduce performance optimisations
> using the common technique of freeing mbuf segments in bulks.
>
> From this perspective, the way of associating SW descriptors
> with individual mbuf segments rather than with whole packets
> was adopted as a key requirement for the entire optimisation.
>
> However, only the fast path reap function was amended to fit
> the new scheme whilst the corresponding function on the port
> stop path was left intact by mistake. This implies incorrect
> usage of rte_pktmbuf_free() with regard to separate segments
> rather than calling rte_pktmbuf_free_seg() and must be fixed.
Good to know you are OK Ivan, I was worried when previous a few
commit logs were not perfectly aligned :)
>
> Fixes: d321954343c8 ("net/sfc: free mbufs in bulks on EF10 native Tx reap")
>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Reviewed-by: Andy Moreton <amoreton@solarflare.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2017-10-23 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 9:39 Andrew Rybchenko
2017-10-23 18:08 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a35c104-6c8c-6b08-3a71-aa02a6142282@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ivan.malov@oktetlabs.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).