From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5] ethdev: add flow API to expand RSS flows
Date: Fri, 29 Jun 2018 17:23:33 +0100 [thread overview]
Message-ID: <5ae59430-1488-abb4-fdee-0f773d0010ab@intel.com> (raw)
In-Reply-To: <20180628160927.GI4025@6wind.com>
On 6/28/2018 5:09 PM, Adrien Mazarguil wrote:
> On Thu, Jun 28, 2018 at 06:01:21PM +0200, Nelio Laranjeiro wrote:
>> Introduce an helper for PMD to expand easily flows items list with RSS
>> action into multiple flow items lists with priority information.
>>
>> For instance a user items list being "eth / end" with rss action types
>> "ipv4-udp ipv6-udp end" needs to be expanded into three items lists:
>>
>> - eth
>> - eth / ipv4 / udp
>> - eth / ipv6 / udp
>>
>> to match the user request. Some drivers are unable to reach such
>> request without this expansion, this API is there to help those.
>> Only PMD should use such API for their internal cooking, the application
>> will still handle a single flow.
>>
>> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>>
>> ---
>>
>> Changes in v5:
>>
>> - Replace the struct rte_flow_expand_rss field by a flexible array,
>> - Address all nits.
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>
> With just a couple of tiny nits, not sure they're worth a v6. See below.
>
> <snip>
>> +/** Node object of input graph for rte_flow_expand_rss(). */
>> +struct rte_flow_expand_node {
>> + const int *const next;
>> + /**< List of next node indexes. Index 0 is interpreted as a
>> + * terminator. */
>> + const enum rte_flow_item_type type;
>> + /**< Pattern item type of current node. */
>> + uint64_t rss_types;
>> + /**< RSS types bit-field associated with this node (see ETH_RSS_*
>> + * definitions).*/
>> +};
>
> Multi-line comments should have opening and closing tokens on dedicated
> lines.
>
> <snip>
>> + * @param[in] graph.
>
> Extra "."
Extra "." is causing doc warning, will fix it while merging. Also will fix above
multi-line doxygen comment syntax while merging.
>
next prev parent reply other threads:[~2018-06-29 16:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 9:54 [dpdk-dev] [DPDK 18.08] " Nelio Laranjeiro
2018-05-28 13:33 ` Wiles, Keith
2018-06-05 8:26 ` [dpdk-dev] [PATCH v2] " Nelio Laranjeiro
2018-06-21 7:25 ` [dpdk-dev] [PATCH v3] " Nelio Laranjeiro
2018-06-27 14:26 ` Thomas Monjalon
2018-06-27 14:55 ` [dpdk-dev] [PATCH v4] " Nelio Laranjeiro
2018-06-28 12:33 ` Adrien Mazarguil
2018-06-28 16:01 ` [dpdk-dev] [PATCH v5] " Nelio Laranjeiro
2018-06-28 16:09 ` Adrien Mazarguil
2018-06-29 16:23 ` Ferruh Yigit [this message]
2018-06-29 16:26 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ae59430-1488-abb4-fdee-0f773d0010ab@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).