From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix wrong handle when enable interrupt
Date: Tue, 11 Apr 2017 12:00:13 +0100 [thread overview]
Message-ID: <5b5c566a-6778-56a7-7e11-bdc50adad097@intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810D1BAE5@SHSMSX103.ccr.corp.intel.com>
On 3/30/2017 1:26 PM, Wu, Jingjing wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
>> Sent: Tuesday, March 21, 2017 7:34 PM
>> To: Thomas Monjalon <thomas.monjalon@6wind.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix wrong handle when enable
>> interrupt
>>
>> Hi Thomas:
>>
>>
>>> -----Original Message-----
>>> From: Zhang, Qi Z
>>> Sent: Tuesday, March 21, 2017 8:10 PM
>>> To: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin
>>> <helin.zhang@intel.com>
>>> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
>>> Subject: [PATCH v2] net/i40e: fix wrong handle when enable interrupt
>>>
>>> In i40e_dev_interrupt_handler, when call rte_intr_enable, the
>>> intr_handle is the copy when we registered.
>>> According to interrupt handle framework, if the requirement of
>>> intr_handle is changed, we need to unregister then register a new
>>> copy. This happens on i40e driver when bind to vfio-pci, the
>>> rte_intr_efd_enable function will modify the max_intr according the
>>> queue number, so a new copy of intr_handle need to be registered.
>>> Without this fix, we saw lw3fwd-power does not work due to wrong
>>> interrupt count in vfio_irq_set when set vfio interrupt.
>>>
>>> Fixes: 2ce7a1ed09fc ("net/i40e: localize mapping of ethdev to PCI
>>> device")
>>>
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>>> ---
>>> v2:
>>> - follow current design, when intr_handle is modified, unregister
>>> the old one and register the new one.
>>> - there should be a patch set to fix on other devices.
>>>
>>> drivers/net/i40e/i40e_ethdev.c | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/net/i40e/i40e_ethdev.c
>>> b/drivers/net/i40e/i40e_ethdev.c index 9c76baa..e7bbea5 100644
>>> --- a/drivers/net/i40e/i40e_ethdev.c
>>> +++ b/drivers/net/i40e/i40e_ethdev.c
>>> @@ -1886,6 +1886,14 @@ i40e_dev_start(struct rte_eth_dev *dev)
>>> ret = rte_intr_efd_enable(intr_handle, intr_vector);
>>> if (ret)
>>> return ret;
>>> + /**
>>> + * intr_handle may be modified in rte_intr_efd_enable
>>> + * so unregster the old one and register the new one.
>>> + */
>>> + rte_intr_callback_unregister(intr_handle,
>>> + i40e_dev_interrupt_handler, dev);
>>> + rte_intr_callback_register(intr_handle,
>>> + i40e_dev_interrupt_handler, dev);
>> To me, this fix looks a little bit weird.
>> May I know why we need to register an copy of intr_handle ?
>> What do you think about my previous clean up patch.
>> http://dpdk.org/dev/patchwork/patch/21529/
>> Thanks
>> Qi.
>
> It seems [dpdk-dev,v2,1/3] vfio: keep interrupt source read only
> http://www.dpdk.org/dev/patchwork/patch/21528/ is already
> be acked by Anatoly.
>
> I think we need to support that change, but not this workaround.
>
No more required after "clean up interrupt handle" patches, patch status
updated to rejected.
prev parent reply other threads:[~2017-04-11 11:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 20:02 [dpdk-dev] [PATCH] " Qi Zhang
2017-02-10 10:03 ` Ferruh Yigit
2017-03-21 12:09 ` [dpdk-dev] [PATCH v2] " Qi Zhang
2017-03-21 11:34 ` Zhang, Qi Z
2017-03-30 12:26 ` Wu, Jingjing
2017-04-11 11:00 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b5c566a-6778-56a7-7e11-bdc50adad097@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).