From: Jie Hai <haijie1@huawei.com>
To: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Cc: <liudongdong3@huawei.com>, <honnappa.nagarahalli@arm.com>,
<dev@dpdk.org>
Subject: Re: [PATCH v2 1/2] ring: add ring list telemetry cmd
Date: Tue, 31 Jan 2023 11:09:36 +0800 [thread overview]
Message-ID: <5b9b9e37-c9bb-9f12-6190-6ab1bc94c318@huawei.com> (raw)
In-Reply-To: <8e561371-f993-8d0a-c147-c86099a33118@yandex.ru>
On 2023/1/23 0:40, Konstantin Ananyev wrote:
> Hi Jie,
>
>> This patch supports the list of rings with telemetry cmd.
>> An example using this command is shown below:
>>
>> --> /ring/list
>> {
>> "/ring/list": [
>> "HT_0000:7d:00.2",
>> "MP_mb_pool_0"
>> ]
>> }
>>
>> Signed-off-by: Jie Hai <haijie1@huawei.com>
>> ---
>> lib/ring/meson.build | 1 +
>> lib/ring/rte_ring.c | 40 ++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 41 insertions(+)
>>
>> diff --git a/lib/ring/meson.build b/lib/ring/meson.build
>> index c20685c689ac..7fca958ed7fa 100644
>> --- a/lib/ring/meson.build
>> +++ b/lib/ring/meson.build
>> @@ -18,3 +18,4 @@ indirect_headers += files (
>> 'rte_ring_rts.h',
>> 'rte_ring_rts_elem_pvt.h',
>> )
>> +deps += ['telemetry']
>> diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c
>> index cddaf6b2876f..bb1dafd4d1ca 100644
>> --- a/lib/ring/rte_ring.c
>> +++ b/lib/ring/rte_ring.c
>> @@ -22,6 +22,7 @@
>> #include <rte_errno.h>
>> #include <rte_string_fns.h>
>> #include <rte_tailq.h>
>> +#include <rte_telemetry.h>
>> #include "rte_ring.h"
>> #include "rte_ring_elem.h"
>> @@ -419,3 +420,42 @@ rte_ring_lookup(const char *name)
>> return r;
>> }
>> +
>> +static void
>> +rte_ring_walk(void (*func)(struct rte_ring *, void *), void *arg)
>
> As a nit: it is a static function, so I think we can skip 'rte_' prefix
> for it.
> Apart from that:
> Acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
>
Hi, Konstantin,
Thanks for your review. Accepted and fixed in v3.
Jie Hai
>> +{
>> + struct rte_ring_list *ring_list;
>> + struct rte_tailq_entry *te;
>> +
>> + ring_list = RTE_TAILQ_CAST(rte_ring_tailq.head, rte_ring_list);
>> + rte_mcfg_tailq_read_lock();
>> +
>> + TAILQ_FOREACH(te, ring_list, next) {
>> + (*func)((struct rte_ring *) te->data, arg);
>> + }
>> +
>> + rte_mcfg_tailq_read_unlock();
>> +}
>> +
>> +static void
>> +ring_list_cb(struct rte_ring *r, void *arg)
>> +{
>> + struct rte_tel_data *d = (struct rte_tel_data *)arg;
>> +
>> + rte_tel_data_add_array_string(d, r->name);
>> +}
>> +
>> +static int
>> +ring_handle_list(const char *cmd __rte_unused,
>> + const char *params __rte_unused, struct rte_tel_data *d)
>> +{
>> + rte_tel_data_start_array(d, RTE_TEL_STRING_VAL);
>> + rte_ring_walk(ring_list_cb, d);
>> + return 0;
>> +}
>> +
>> +RTE_INIT(ring_init_telemetry)
>> +{
>> + rte_telemetry_register_cmd("/ring/list", ring_handle_list,
>> + "Returns list of available ring. Takes no parameters");
>> +}
>
> .
next prev parent reply other threads:[~2023-01-31 3:09 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 9:10 [PATCH 0/2] add ring telemetry cmds Jie Hai
2023-01-17 9:10 ` [PATCH 1/2] ring: add ring list telemetry cmd Jie Hai
2023-01-17 9:10 ` [PATCH 2/2] ring: add ring info " Jie Hai
2023-01-17 13:03 ` [PATCH v2 0/2] add ring telemetry cmds Jie Hai
2023-01-17 13:03 ` [PATCH v2 1/2] ring: add ring list telemetry cmd Jie Hai
2023-01-22 16:40 ` Konstantin Ananyev
2023-01-31 3:09 ` Jie Hai [this message]
2023-01-17 13:03 ` [PATCH v2 2/2] ring: add ring info " Jie Hai
2023-01-22 17:49 ` Konstantin Ananyev
2023-01-31 3:11 ` Jie Hai
2023-01-31 2:28 ` [PATCH v3 0/2] add ring telemetry cmds Jie Hai
2023-01-31 2:28 ` [PATCH v3 1/2] ring: add ring list telemetry cmd Jie Hai
2023-01-31 16:44 ` Honnappa Nagarahalli
2023-02-03 7:20 ` Jie Hai
2023-01-31 2:28 ` [PATCH v3 2/2] ring: add ring info " Jie Hai
2023-01-31 16:44 ` Honnappa Nagarahalli
2023-02-03 7:04 ` Jie Hai
2023-02-02 13:07 ` Konstantin Ananyev
2023-02-03 7:28 ` Jie Hai
2023-02-10 2:48 ` [PATCH v4 0/3] add telemetry cmds for ring Jie Hai
2023-02-10 2:48 ` [PATCH v4 1/3] ring: fix unmatched type definition and usage Jie Hai
2023-02-10 2:48 ` [PATCH v4 2/3] ring: add telemetry cmd to list rings Jie Hai
2023-02-16 6:56 ` lihuisong (C)
2023-02-10 2:48 ` [PATCH v4 3/3] ring: add telemetry cmd for ring info Jie Hai
2023-02-14 23:13 ` Konstantin Ananyev
2023-02-16 6:54 ` lihuisong (C)
2023-02-20 12:55 ` David Marchand
2023-06-20 8:14 ` Jie Hai
2023-06-20 14:34 ` Thomas Monjalon
2023-07-04 8:04 ` Jie Hai
2023-07-04 14:11 ` Thomas Monjalon
2023-07-06 8:52 ` David Marchand
2023-07-07 2:18 ` Jie Hai
2023-02-15 3:04 ` [PATCH v4 0/3] add telemetry cmds for ring fengchengwen
2023-05-09 1:29 ` [PATCH v5 " Jie Hai
2023-05-09 1:29 ` [PATCH v5 1/3] ring: fix unmatched type definition and usage Jie Hai
2023-05-09 6:23 ` Ruifeng Wang
2023-05-09 8:15 ` Jie Hai
2023-05-09 1:29 ` [PATCH v5 2/3] ring: add telemetry cmd to list rings Jie Hai
2023-05-09 1:29 ` [PATCH v5 3/3] ring: add telemetry cmd for ring info Jie Hai
2023-05-09 6:50 ` Morten Brørup
2023-05-09 9:24 ` [PATCH v6 0/3] add telemetry cmds for ring Jie Hai
2023-05-09 9:24 ` [PATCH v6 1/3] ring: fix unmatched type definition and usage Jie Hai
2023-05-09 9:24 ` [PATCH v6 2/3] ring: add telemetry cmd to list rings Jie Hai
2023-05-09 9:24 ` [PATCH v6 3/3] ring: add telemetry cmd for ring info Jie Hai
2023-05-30 9:27 ` [PATCH v6 0/3] add telemetry cmds for ring Jie Hai
2023-06-12 14:54 ` Thomas Monjalon
2023-10-28 9:48 ` Jie Hai
2023-07-04 9:04 ` [PATCH v7 " Jie Hai
2023-07-04 9:04 ` [PATCH v7 1/3] ring: fix unmatched type definition and usage Jie Hai
2023-07-04 9:04 ` [PATCH v7 2/3] ring: add telemetry cmd to list rings Jie Hai
2023-07-04 9:04 ` [PATCH v7 3/3] ring: add telemetry cmd for ring info Jie Hai
2023-08-18 6:53 ` [PATCH v7 0/3] add telemetry cmds for ring Jie Hai
2023-09-12 1:52 ` Jie Hai
2023-10-10 2:25 ` Jie Hai
2023-10-25 1:22 ` Jie Hai
2023-10-28 9:50 ` Jie Hai
2023-11-08 2:55 ` lihuisong (C)
2023-11-09 10:20 ` [RESEND " Jie Hai
2023-11-09 10:20 ` [RESEND v7 1/3] ring: fix unmatched type definition and usage Jie Hai
2023-11-09 12:26 ` lihuisong (C)
2024-02-18 18:11 ` Thomas Monjalon
2024-02-19 8:24 ` Jie Hai
2023-11-09 10:20 ` [RESEND v7 2/3] ring: add telemetry cmd to list rings Jie Hai
2023-11-09 12:26 ` lihuisong (C)
2023-11-09 10:20 ` [RESEND v7 3/3] ring: add telemetry cmd for ring info Jie Hai
2023-11-09 12:27 ` lihuisong (C)
2024-01-27 8:33 ` [RESEND v7 0/3] add telemetry cmds for ring Jie Hai
2024-02-19 8:32 ` [PATCH v8 0/2] " Jie Hai
2024-02-19 8:32 ` [PATCH v8 1/2] ring: add telemetry cmd to list rings Jie Hai
2024-02-19 8:32 ` [PATCH v8 2/2] ring: add telemetry cmd for ring info Jie Hai
2024-02-19 10:09 ` [PATCH v8 0/2] add telemetry cmds for ring Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b9b9e37-c9bb-9f12-6190-6ab1bc94c318@huawei.com \
--to=haijie1@huawei.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=liudongdong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).