From: Maryam Tahhan <mtahhan@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: ferruh.yigit@amd.com, stephen@networkplumber.org,
lihuisong@huawei.com, fengchengwen@huawei.com,
liuyonglong@huawei.com, dev@dpdk.org
Subject: Re: [v1] net/af_xdp: enable a sock path alongside use_cni
Date: Fri, 1 Dec 2023 10:31:40 +0000 [thread overview]
Message-ID: <5c1d1ed6-cd5b-441e-acbc-6a151f97f148@redhat.com> (raw)
In-Reply-To: <CAJFAV8zfQq7MAE_qEVc2BzYkSKfGLugj3_xwnNxy6JedYtbNdg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2358 bytes --]
On 01/12/2023 10:26, David Marchand wrote:
> Hello,
>
> On Thu, Nov 30, 2023 at 10:13 AM Maryam Tahhan<mtahhan@redhat.com> wrote:
> [snip]
>> diff --git a/doc/guides/howto/af_xdp_cni.rst b/doc/guides/howto/af_xdp_cni.rst
>> index a1a6d5b99c..a2d90c665d 100644
>> --- a/doc/guides/howto/af_xdp_cni.rst
>> +++ b/doc/guides/howto/af_xdp_cni.rst
>> @@ -38,9 +38,10 @@ The XSKMAP is a BPF map of AF_XDP sockets (XSK).
>> The client can then proceed with creating an AF_XDP socket
>> and inserting that socket into the XSKMAP pointed to by the descriptor.
>>
>> -The EAL vdev argument ``use_cni`` is used to indicate that the user wishes
>> +The EAL vdev arguments ``use_cni`` and ``sock`` are used to indicate that the user wishes
>> to run the PMD in unprivileged mode and to receive the XSKMAP file descriptor
>> from the CNI.
>> +
>> When this flag is set,
>> the ``XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD`` libbpf flag
>> should be used when creating the socket
>> @@ -49,7 +50,7 @@ Instead the loading is handled by the CNI.
>>
>> .. note::
>>
>> - The Unix Domain Socket file path appear in the end user is "/tmp/afxdp.sock".
>> + The Unix Domain Socket file path appears to the end user at "/tmp/afxdp_dp/<netdev>/afxdp.sock".
>>
>>
>> Prerequisites
>> @@ -224,7 +225,6 @@ Howto run dpdk-testpmd with CNI plugin:
>> capabilities:
>> add:
>> - CAP_NET_RAW
>> - - CAP_BPF
>> resources:
>> requests:
>> hugepages-2Mi: 2Gi
>> @@ -245,7 +245,17 @@ Howto run dpdk-testpmd with CNI plugin:
>>
>> kubectl exec -i <Pod name> --container <containers name> -- \
>> /<Path>/dpdk-testpmd -l 0,1 --no-pci \
>> - --vdev=net_af_xdp0,use_cni=1,iface=<interface name> \
>> + --vdev=net_af_xdp0,use_cni=1,iface=<interface name>,sock=/tmp/afxdp_dp/<interface name>/afxdp.sock \
>> + -- --no-mlockall --in-memory
> Quick look at the doc update.
> - is this hunk related to $subject?
> - --in-memory is not a testpmd level option, but an EAL one.
>
>
Yeah - I actually will remove the `--no-mlockall --in-memory` in the v2
respin (it's a typo). I'm only interested in showing the multiple af_xdp
device (vdev) arguments. I think it's useful for anyone who is looking
for a quick reference on how to do it.
[-- Attachment #2: Type: text/html, Size: 2933 bytes --]
next prev parent reply other threads:[~2023-12-01 10:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 9:13 Maryam Tahhan
2023-11-30 12:14 ` Koikkara Reeny, Shibin
2023-11-30 12:32 ` Maryam Tahhan
2023-11-30 13:55 ` Koikkara Reeny, Shibin
2023-11-30 13:56 ` Koikkara Reeny, Shibin
2023-11-30 14:17 ` Maryam Tahhan
2023-12-01 9:55 ` Koikkara Reeny, Shibin
2023-12-01 10:20 ` Maryam Tahhan
2023-12-01 10:49 ` Koikkara Reeny, Shibin
2023-11-30 14:30 ` Maryam Tahhan
2023-12-01 10:26 ` David Marchand
2023-12-01 10:31 ` Maryam Tahhan [this message]
2023-12-01 10:33 ` Maryam Tahhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c1d1ed6-cd5b-441e-acbc-6a151f97f148@redhat.com \
--to=mtahhan@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).