From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Declan Doherty <declan.doherty@intel.com>, dev@dpdk.org
Cc: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5] net/bond: fixes for link properties management
Date: Wed, 5 Jul 2017 18:24:20 +0100 [thread overview]
Message-ID: <5c2cb123-75b5-66f8-12c5-85a8015dd4fc@intel.com> (raw)
In-Reply-To: <20170705170912.31346-1-declan.doherty@intel.com>
On 7/5/2017 6:09 PM, Declan Doherty wrote:
> From: Tomasz Kulasek <tomaszx.kulasek@intel.com>
>
> This patch fixes the management of link properties in the bonded device.
>
> In all mode except mode 4 a bonded device link will default to reporting
> the link as full duplex and auto-neg. The link speed for a bond port is
> calculated on it's active slaves and the particular mode it is running
> in. The bonding link speed is reported based on the transmit link as in
> some modes link speed between egress/ingress is not symmetrical.
>
> - round-robin, balance, 802.3ad, TLB and ALB modes all report the link
> speed as the sum of the speed of each active slave.
> - active backup link speed is reported as the speed of the current
> primary slave
> - broadcast is reported as the minimum of value of the active slaves
> link speeds.
>
> In mode 4 (link aggregation 802.3ad) the properties of the first slave
> added to the bonded device are slave and subsequent slaves are verified
> to have the same properties.
>
> Finally in the bond_ethdev_lsc_event_callback function the link
> properties of the device are updated after any change to the number of
> active slaves.
>
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
Gcc is throwing another warning [1].
And can you please send next version as full patchset, for the sake of
the traceability of merged patches in the future.
[1]
.../dpdk/drivers/net/bonding/rte_eth_bond_pmd.c: In function
‘bond_ethdev_lsc_event_callback’:
.../dpdk/drivers/net/bonding/rte_eth_bond_pmd.c:2472:39: error: variable
‘slave_eth_dev’ set but not used [-Werror=unused-but-set-variable]
struct rte_eth_dev *bonded_eth_dev, *slave_eth_dev;
^~~~~~~~~~~~~
next prev parent reply other threads:[~2017-07-05 17:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 19:54 [dpdk-dev] [PATCH] bonding: allow to create master bonding Tomasz Kulasek
2017-06-29 17:30 ` [dpdk-dev] [PATCH v2] " Tomasz Kulasek
2017-07-05 14:58 ` [dpdk-dev] [PATCH v3 1/2] net/bond: fixes for link properties management Declan Doherty
2017-07-05 14:58 ` [dpdk-dev] [PATCH v3 2/2] net/bond: allow slaves to also be bonded devices Declan Doherty
2017-07-05 16:30 ` [dpdk-dev] [PATCH v4 1/2] net/bond: fixes for link properties management Declan Doherty
2017-07-05 16:30 ` [dpdk-dev] [PATCH v4 2/2] net/bond: allow slaves to also be bonded devices Declan Doherty
2017-07-05 17:09 ` [dpdk-dev] [PATCH v5] net/bond: fixes for link properties management Declan Doherty
2017-07-05 17:24 ` Ferruh Yigit [this message]
2017-07-05 18:54 ` [dpdk-dev] [PATCH v6 1/2] " Declan Doherty
2017-07-05 18:54 ` [dpdk-dev] [PATCH v6 2/2] net/bond: allow slaves to also be bonded devices Declan Doherty
2017-07-06 9:33 ` [dpdk-dev] [PATCH v6 1/2] net/bond: fixes for link properties management Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c2cb123-75b5-66f8-12c5-85a8015dd4fc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).