From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Kumara Parameshwaran <kumaraparamesh92@gmail.com>,
hujiayu.hu@foxmail.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v8] app/testpmd : fix packets not getting flushed in heavy-weight mode API
Date: Wed, 21 Feb 2024 18:02:24 +0000 [thread overview]
Message-ID: <5ccd235e-aae7-4ac9-8eef-fa6e0483b1cc@amd.com> (raw)
In-Reply-To: <8c3d602b-b83b-4cb6-af04-f51576d72284@amd.com>
On 2/16/2024 1:56 PM, Ferruh Yigit wrote:
> On 2/16/2024 3:47 AM, Kumara Parameshwaran wrote:
>> In heavy-weight mode GRO which is based on timer, the GRO packets
>> will not be flushed in spite of timer expiry if there is no packet
>> in the current poll. If timer mode GRO is enabled the
>> rte_gro_timeout_flush API should be invoked.
>>
>> Fixes: b7091f1dcfbc ("app/testpmd: enable the heavyweight mode TCP/IPv4 GRO")
>> Cc: hujiayu.hu@foxmail.com
>>
>> Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
>> ---
>> v1:
>> Changes to make sure that the GRO flush API is invoked if there are no packets in
>> current poll and timer expiry.
>>
>> v2:
>> Fix code organisation issue
>>
>> v3:
>> Fix warnings
>>
>> v4:
>> Fix error and warnings
>>
>> v5:
>> Fix compilation issue when GRO is not defined
>>
>> v6:
>> Address review comments
>>
>> v7:
>> Address review comments
>>
>> v8:
>> Fix spell check warnings
>>
>> app/test-pmd/csumonly.c | 22 ++++++++++++++++++----
>> 1 file changed, 18 insertions(+), 4 deletions(-)
>>
>> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
>> index c103e54111..a922160f6d 100644
>> --- a/app/test-pmd/csumonly.c
>> +++ b/app/test-pmd/csumonly.c
>> @@ -863,16 +863,29 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
>>
>> /* receive a burst of packet */
>> nb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst);
>> - if (unlikely(nb_rx == 0))
>> + if (unlikely(nb_rx == 0)) {
>> +#ifndef RTE_LIB_GRO
>> return false;
>> +#else
>> + gro_enable = gro_ports[fs->rx_port].enable;
>> + /*
>> + * Make sure that in case of Heavyweight mode GRO the packets in
>> + * GRO cache should be flushed as the timer could have expired.
>> + *
>> + * The order of conditions should be the same as gro_ctx is valid
>> + * only when gro_flush_cycles is not the GRO_DEFAULT_FLUSH_CYCLES which
>> + * indicates light weight mode GRO
>> + */
>>
>
> Updated comment as below to make it terse, what do you think:
> /*
> * Check if packets need to be flushed in the GRO context
> * due to a timeout.
> *
> * Continue only in GRO heavyweight mode and if there are
> * packets in the GRO context.
> */
>
>
>> + if (!gro_enable || (gro_flush_cycles == GRO_DEFAULT_FLUSH_CYCLES) ||
>> + (rte_gro_get_pkt_count(current_fwd_lcore()->gro_ctx) == 0))
>> + return false;
>> +#endif
>> + }
>>
>
> Another issue but also related to your patch, if there is no packet to
> Tx after GRO block, should we add another zero packet check:
> if (unlikely(nb_rx == 0))
> return false;
>
> To prevent executing GSO and Tx path code with zero packet, do you think
> does this make sense?
>
>
Patch looks good to me, with above comment update, but I am worried
about side impacts of this patch that we might be missing, that is why I
would like it to be in -rc1, so that it can be tested better. Hence,
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
(Updated comment as suggested above while merging.)
Lets continue to discuss return on "nb_rx == 0" case after GRO block,
incremental to this patch.
next prev parent reply other threads:[~2024-02-21 18:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 19:52 [PATCH v1] gro : " Kumara Parameshwaran
2024-01-17 19:57 ` kumaraparameshwaran rathinavel
2024-01-17 20:14 ` [PATCH v2] " Kumara Parameshwaran
2024-01-17 20:20 ` [PATCH v3] " Kumara Parameshwaran
2024-01-17 20:24 ` [PATCH v4] " Kumara Parameshwaran
2024-01-18 8:36 ` [PATCH v5] " Kumara Parameshwaran
2024-02-07 22:57 ` Ferruh Yigit
2024-02-11 4:55 ` [PATCH v6] " Kumara Parameshwaran
2024-02-12 15:05 ` Ferruh Yigit
2024-02-16 3:40 ` [PATCH v7] app/testpmd : fix " Kumara Parameshwaran
2024-02-16 4:13 ` Stephen Hemminger
2024-02-16 3:47 ` [PATCH v8] " Kumara Parameshwaran
2024-02-16 13:56 ` Ferruh Yigit
2024-02-21 18:02 ` Ferruh Yigit [this message]
2024-02-22 11:15 ` kumaraparameshwaran rathinavel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ccd235e-aae7-4ac9-8eef-fa6e0483b1cc@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=hujiayu.hu@foxmail.com \
--cc=kumaraparamesh92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).