From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>, dev@dpdk.org
Cc: tiwei.bie@intel.com, ray.kinsella@intel.com,
zhihong.wang@intel.com, kuralamudhan.ramakrishnan@intel.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3 2/9] eal: don't allow legacy mode with in-memory mode
Date: Mon, 17 Sep 2018 10:49:48 +0100 [thread overview]
Message-ID: <5ccd5ac1-e01a-2416-035b-d7b3bb2d7a07@intel.com> (raw)
In-Reply-To: <ef1e0be9-6bb4-f253-8ab7-49579d5be45b@redhat.com>
On 13-Sep-18 2:06 PM, Maxime Coquelin wrote:
>
>
> On 09/04/2018 05:15 PM, Anatoly Burakov wrote:
>> In-memory mode was never meant to support legacy mode, because we
>> cannot sort anonymous pages anyway.
>>
>> Fixes: 72b49ff623c4 ("mem: support --in-memory mode")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> ---
>> lib/librte_eal/common/eal_common_options.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/lib/librte_eal/common/eal_common_options.c
>> b/lib/librte_eal/common/eal_common_options.c
>> index dd5f97402..873099acc 100644
>> --- a/lib/librte_eal/common/eal_common_options.c
>> +++ b/lib/librte_eal/common/eal_common_options.c
>> @@ -1390,6 +1390,12 @@ eal_check_common_options(struct internal_config
>> *internal_cfg)
>> "--"OPT_HUGE_UNLINK"\n");
>> return -1;
>> }
>> + if (internal_cfg->legacy_mem &&
>> + internal_cfg->in_memory) {
>> + RTE_LOG(ERR, EAL, "Option --"OPT_LEGACY_MEM" is not compatible "
>> + "with --"OPT_IN_MEMORY"\n");
>
> This is a general comment, as it is consistent with the style of the
> file. I generally prefer not splitting error strings into multiple lines
> even if it is longer than 80 chars, because it makes grepping for the
> error string more difficult.
I agree in general, however in this particular case the string is
ungreppable (it is a word now!) anyway because it's split into a few pieces.
>
>> + return -1;
>> + }
>> return 0;
>> }
>>
>
> Other than that:
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Thanks,
> Maxime
>
--
Thanks,
Anatoly
prev parent reply other threads:[~2018-09-17 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1536073996.git.anatoly.burakov@intel.com>
[not found] ` <cover.1536072550.git.anatoly.burakov@intel.com>
[not found] ` <cover.1535041359.git.anatoly.burakov@intel.com>
2018-08-23 16:59 ` [dpdk-stable] [PATCH 1/8] fbarray: fix detach in noshconf mode Anatoly Burakov
2018-08-23 16:59 ` [dpdk-stable] [PATCH 2/8] eal: don't allow legacy mode with in-memory mode Anatoly Burakov
2018-09-04 15:01 ` [dpdk-stable] [PATCH v2 1/9] fbarray: fix detach in noshconf mode Anatoly Burakov
2018-09-04 15:01 ` [dpdk-stable] [PATCH v2 2/9] eal: don't allow legacy mode with in-memory mode Anatoly Burakov
2018-09-04 15:15 ` [dpdk-stable] [PATCH v3 1/9] fbarray: fix detach in noshconf mode Anatoly Burakov
2018-09-13 13:00 ` Maxime Coquelin
2018-09-04 15:15 ` [dpdk-stable] [PATCH v3 2/9] eal: don't allow legacy mode with in-memory mode Anatoly Burakov
2018-09-13 13:06 ` Maxime Coquelin
2018-09-17 9:49 ` Burakov, Anatoly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ccd5ac1-e01a-2416-035b-d7b3bb2d7a07@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=kuralamudhan.ramakrishnan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=ray.kinsella@intel.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).