From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>,
"Wang, Xiao W" <xiao.w.wang@intel.com>
Cc: "Xia, Chenbo" <chenbo.xia@intel.com>,
"Liu, Yong" <yong.liu@intel.com>, dev <dev@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
dpdk stable <stable@dpdk.org>,
"yangyi01@inspur.com" <yangyi01@inspur.com>
Subject: Re: [dpdk-stable] [PATCH v3] vhost: add header check in dequeue offload
Date: Tue, 13 Apr 2021 16:30:31 +0200 [thread overview]
Message-ID: <5ddd6f84-e607-f19f-2fb8-8988db6a7627@redhat.com> (raw)
In-Reply-To: <CAJFAV8xE8JDnMM82ATOFPgtf3bCNQnYBETzUj2tHG5HnWTD4Rg@mail.gmail.com>
On 4/12/21 11:33 AM, David Marchand wrote:
> On Mon, Apr 12, 2021 at 11:09 AM Wang, Xiao W <xiao.w.wang@intel.com> wrote:
>> Considering the major consumer of vhost API is virtual switch/router, I tend to keep the current implementation and apply this fix patch.
>> Any comments?
>
> This is just a hack that bypasses the vswitch control.
>
> It happens to work when the vswitch does nothing.
> If anything is done, like popping a vlan header, the vswitch needs to
> update l3 offset.
>
>
I agree with David, current behavior is wrong.
Furthermore, when the lib is used via the Vhost PMD, the application
should not have to handle it differently on whether it is Vhost PMD or
any physical NIC PMD.
next prev parent reply other threads:[~2021-04-13 14:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 6:38 [dpdk-stable] [PATCH] " Xiao Wang
2021-03-11 10:38 ` [dpdk-stable] [dpdk-dev] " Ananyev, Konstantin
2021-03-12 15:19 ` Wang, Xiao W
2021-03-15 15:32 ` [dpdk-stable] [PATCH v2] " Xiao Wang
2021-03-15 16:17 ` David Marchand
2021-03-15 18:53 ` Ananyev, Konstantin
2021-03-16 9:13 ` Wang, Xiao W
2021-03-17 6:31 ` [dpdk-stable] [PATCH v3] " Xiao Wang
2021-04-01 12:04 ` David Marchand
2021-04-02 8:38 ` Wang, Xiao W
2021-04-12 9:08 ` Wang, Xiao W
2021-04-12 9:33 ` David Marchand
2021-04-13 14:30 ` Maxime Coquelin [this message]
2021-05-08 5:54 ` Wang, Xiao W
2021-06-15 6:35 ` [dpdk-stable] [PATCH v4] vhost: check header for legacy " Xiao Wang
2021-06-15 7:57 ` [dpdk-stable] [dpdk-dev] " David Marchand
2021-06-16 14:33 ` Wang, Xiao W
2021-06-21 8:21 ` [dpdk-stable] [PATCH v5] " Xiao Wang
2021-07-13 9:34 ` Maxime Coquelin
2021-07-20 2:43 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ddd6f84-e607-f19f-2fb8-8988db6a7627@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=xiao.w.wang@intel.com \
--cc=yangyi01@inspur.com \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).