From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jerin Jacob <jerinjacobk@gmail.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
dpdk-dev <dev@dpdk.org>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Jerin Jacob <jerinj@marvell.com>, Ori Kam <orika@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] doc: remove flow API from the feature list
Date: Fri, 10 Apr 2020 09:44:39 +0100 [thread overview]
Message-ID: <5defdf9b-7c1d-f4e2-9bd7-6de55ef452e5@intel.com> (raw)
In-Reply-To: <CALBAE1N_C0UZByG6RthrsHW6iK+GE=ZT2TEjM8Mf34On-REWcg@mail.gmail.com>
On 10/25/2019 2:39 PM, Jerin Jacob wrote:
> On Fri, Oct 25, 2019 at 6:56 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>>
>> 25/10/2019 14:51, Ferruh Yigit:
>>> "Flow API" is a method/API to implement various filtering features, on
>>> its own it doesn't give much context on what features are provided. And
>>> it is not really a feature, so doesn't fit into feature table.
>>>
>>> Also since other filtering related APIs, 'filter_ctrl', has been
>>> deprecated, flow API is the only supported way in the DPDK to implement
>>> filtering options, if related filter options announced by PMDs, listing
>>> "Flow API" as implemented is redundant information.
>>
>> I fully agree with this explanation.
>> rte_flow is the only supported API for flow offloads.
>> That's why we must remove the legacy API.
>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> ---
>>> --- a/doc/guides/nics/features/default.ini
>>> +++ b/doc/guides/nics/features/default.ini
>>> -Flow API =
>>
>> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
> # Need to remove "Flow API" from doc/guides/nics/features.rst
+1
> # Need to remove refference of "Flow API" from "doc/guides/nics/*" as well.
"Flow API" is the implementation of the filtering, it may exist in the nic
documentation, only it is not a feature on itself. I will scan the docs for usage.
>
> Not specific to this patch,
> Probably we need to add a new matrix to enumerate PATTERN and ACTIONS
> supported by each PMD as a rte_flow feature matrix.
> That some else can take it up if everyone agrees the semantics.
>
+1, there needs a way to figure out which filtering is supported by a
device/driver. It is not documented and it is very hard to got it from the code.
Not sure if a new matrix is the good way to go, but I agree we need some way to
clarify it.
next prev parent reply other threads:[~2020-04-10 8:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 12:51 [dpdk-dev] [PATCH 1/2] doc: add PMD filtering features back Ferruh Yigit
2019-10-25 12:51 ` [dpdk-dev] [PATCH 2/2] doc: remove flow API from the feature list Ferruh Yigit
2019-10-25 13:26 ` Thomas Monjalon
2019-10-25 13:39 ` Jerin Jacob
2020-04-10 8:44 ` Ferruh Yigit [this message]
2020-04-10 8:56 ` Thomas Monjalon
2020-04-10 9:04 ` Jerin Jacob
2020-04-10 9:20 ` Thomas Monjalon
2020-04-10 9:27 ` Ferruh Yigit
2019-10-25 13:23 ` [dpdk-dev] [PATCH 1/2] doc: add PMD filtering features back Thomas Monjalon
2020-04-10 8:53 ` Ferruh Yigit
2020-04-10 9:29 ` [dpdk-dev] [PATCH v2] doc: remove flow API from the feature list Ferruh Yigit
2020-04-10 9:29 ` [dpdk-dev] [PATCH v2 1/2] doc: add PMD filtering features back Ferruh Yigit
2020-04-10 9:29 ` [dpdk-dev] [PATCH v2 2/2] doc: remove flow API from the feature list Ferruh Yigit
2020-04-10 12:10 ` Jerin Jacob
2020-04-10 12:34 ` Thomas Monjalon
2020-04-10 12:38 ` Jerin Jacob
2020-04-10 12:22 ` [dpdk-dev] [PATCH v2 1/2] doc: add PMD filtering features back Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5defdf9b-7c1d-f4e2-9bd7-6de55ef452e5@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=ajit.khaparde@broadcom.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=orika@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).