From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Mike Pattrick <mkp@redhat.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Cc: ktraynor@redhat.com, dev@dpdk.org
Subject: Re: [PATCH v7] app/testpmd: expand noisy neighbour forward mode support
Date: Thu, 8 Jun 2023 15:32:11 +0100 [thread overview]
Message-ID: <5e199328-c626-8de0-7aef-de5bf23ee245@amd.com> (raw)
In-Reply-To: <20230608133144.567391-1-mkp@redhat.com>
On 6/8/2023 2:31 PM, Mike Pattrick wrote:
> Previously the noisy neighbour vnf simulation would only operate in io
> mode, forwarding packets as is. However, this limited the usefulness of
> noisy neighbour simulation.
>
> This feature has now been expanded to supporting mac, macswap, and
> 5tswap modes. To facilitate adding this support, some new header files
> were added.
>
> Signed-off-by: Mike Pattrick <mkp@redhat.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
> @@ -4052,9 +4052,16 @@ rxtx_config_display(void)
> {
> portid_t pid;
> queueid_t qid;
> + char buf[32];
> +
> + if (cur_fwd_eng->status)
> + snprintf(buf, sizeof(buf), " (%s)", cur_fwd_eng->status);
> + else
> + buf[0] = '\0';
>
> - printf(" %s packet forwarding%s packets/burst=%d\n",
> + printf(" %s%s packet forwarding%s packets/burst=%d\n",
> cur_fwd_eng->fwd_mode_name,
> + buf,
> retry_enabled == 0 ? "" : " with retry",
> nb_pkt_per_burst);
>
> @@ -4816,10 +4823,17 @@ pkt_fwd_config_display(struct fwd_config *cfg)
> struct fwd_stream *fs;
> lcoreid_t lc_id;
> streamid_t sm_id;
> + char buf[32];
> +
> + if (cfg->fwd_eng->status)
> + snprintf(buf, sizeof(buf), " (%s)", cfg->fwd_eng->status);
> + else
> + buf[0] = '\0';
>
> - printf("%s packet forwarding%s - ports=%d - cores=%d - streams=%d - "
> + printf("%s%s packet forwarding%s - ports=%d - cores=%d - streams=%d - "
> "NUMA support %s, MP allocation mode: %s\n",
> cfg->fwd_eng->fwd_mode_name,
> + buf,
> retry_enabled == 0 ? "" : " with retry",
> cfg->nb_fwd_ports, cfg->nb_fwd_lcores, cfg->nb_fwd_streams,
> numa_support == 1 ? "enabled" : "disabled",
Removed interim 'buf' variable (and 'cfg->fwd_eng->status' specific
check), and updated as following while merging:
```
- printf(" %s packet forwarding%s packets/burst=%d\n",
+ printf(" %s%s%s packet forwarding%s packets/burst=%d\n",
cur_fwd_eng->fwd_mode_name,
+ cur_fwd_eng->status ? "-" : "",
+ cur_fwd_eng->status ? cur_fwd_eng->status : "",
```
prev parent reply other threads:[~2023-06-08 14:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 18:55 [PATCH v3] " Mike Pattrick
2023-05-26 15:34 ` Kevin Traynor
2023-05-26 17:32 ` Mike Pattrick
2023-06-01 16:23 ` Kevin Traynor
2023-06-06 14:17 ` Ferruh Yigit
2023-06-02 18:29 ` [PATCH v4] " Mike Pattrick
2023-06-06 14:27 ` Ferruh Yigit
2023-06-06 21:12 ` [PATCH v5] " Mike Pattrick
2023-06-06 21:37 ` Ferruh Yigit
2023-06-06 21:42 ` Ferruh Yigit
2023-06-06 22:23 ` Ferruh Yigit
2023-06-07 15:42 ` Mike Pattrick
2023-06-08 9:59 ` [PATCH v6] " Mike Pattrick
2023-06-08 10:25 ` Ferruh Yigit
2023-06-08 10:43 ` Mike Pattrick
2023-06-08 11:42 ` Ferruh Yigit
2023-06-08 13:31 ` [PATCH v7] " Mike Pattrick
2023-06-08 14:32 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e199328-c626-8de0-7aef-de5bf23ee245@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=mkp@redhat.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).