From: Akhil Goyal <akhil.goyal@nxp.com>
To: Abhinandan Gujjar <abhinandan.gujjar@intel.com>,
jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com,
dev@dpdk.org
Cc: pablo.de.lara.guarch@intel.com, declan.doherty@intel.com,
narender.vangati@intel.com, nikhil.rao@intel.com,
Gage Eads <gage.eads@intel.com>
Subject: Re: [dpdk-dev] [dpdk-dev, v1, 2/5] eventdev: add crypto adapter implementation
Date: Tue, 17 Apr 2018 19:48:27 +0530 [thread overview]
Message-ID: <5ea61576-9124-266a-00e6-cb9f22a37f59@nxp.com> (raw)
In-Reply-To: <1522824999-61614-1-git-send-email-abhinandan.gujjar@intel.com>
Hi Abhinandan,
I have not reviewed the patch completely. But I have below query for
further review.
On 4/4/2018 12:26 PM, Abhinandan Gujjar wrote:
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Signed-off-by: Gage Eads <gage.eads@intel.com>
> ---
[..snip..]
> +
> +int __rte_experimental
> +rte_event_crypto_adapter_queue_pair_add(uint8_t id,
> + uint8_t cdev_id,
> + int32_t queue_pair_id)
> +{
> + struct rte_event_crypto_adapter *adapter;
> + struct rte_eventdev *dev;
> + struct crypto_device_info *dev_info;
> + uint32_t cap;
> + int ret;
> +
> + RTE_EVENT_CRYPTO_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
> +
> + if (!rte_cryptodev_pmd_is_valid_dev(cdev_id)) {
> + RTE_EDEV_LOG_ERR("Invalid dev_id=%" PRIu8, cdev_id);
> + return -EINVAL;
> + }
> +
> + adapter = eca_id_to_adapter(id);
> + if (adapter == NULL)
> + return -EINVAL;
> +
> + dev = &rte_eventdevs[adapter->eventdev_id];
> + ret = rte_event_crypto_adapter_caps_get(adapter->eventdev_id,
> + cdev_id,
> + &cap);
> + if (ret) {
> + RTE_EDEV_LOG_ERR("Failed to get adapter caps dev %" PRIu8
> + "cdev %" PRIu8, id, cdev_id);
> + return ret;
> + }
> +
> + dev_info = &adapter->cdevs[cdev_id];
> +
> + if (queue_pair_id != -1 &&
> + (uint16_t)queue_pair_id >= dev_info->dev->data->nb_queue_pairs) {
> + RTE_EDEV_LOG_ERR("Invalid queue_pair_id %" PRIu16,
> + (uint16_t)queue_pair_id);
> + return -EINVAL;
> + }
> +
> + if (cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT) {
> + RTE_FUNC_PTR_OR_ERR_RET(
> + *dev->dev_ops->crypto_adapter_queue_pair_add,
> + -ENOTSUP);
> + if (dev_info->qpairs == NULL) {
> + dev_info->qpairs =
> + rte_zmalloc_socket(adapter->mem_name,
> + dev_info->dev->data->nb_queue_pairs *
> + sizeof(struct crypto_queue_pair_info),
> + 0, adapter->socket_id);
> + if (dev_info->qpairs == NULL)
> + return -ENOMEM;
> + }
> +
> + ret = (*dev->dev_ops->crypto_adapter_queue_pair_add)(dev,
> + dev_info->dev,
> + queue_pair_id);
crypto_adapter_queue_pair_add is supposed to attach a queue
(queue_pair_id) of cryptodev(dev_info->dev) to event device (dev).
But how will the underlying implementation attach it to event device
without knowing the eventdev queue_id. This information was coming in
the RFC patches with the parameter (rte_event_crypto_queue_pair_conf).
Why is this removed and if removed how will the driver attach the queue.
I can see that rte_event is passed in the session private data but how
can we attach the crypto queue with event dev queue?
Regards,
Akhil
next prev parent reply other threads:[~2018-04-17 14:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 6:56 Abhinandan Gujjar
2018-04-17 14:18 ` Akhil Goyal [this message]
2018-04-18 6:21 ` Gujjar, Abhinandan S
2018-04-20 11:34 ` Akhil Goyal
2018-04-20 12:09 ` Gujjar, Abhinandan S
2018-04-20 13:14 ` Jerin Jacob
2018-04-23 6:39 ` Akhil Goyal
2018-04-23 6:49 ` Gujjar, Abhinandan S
2018-04-20 12:48 ` Verma, Shally
2018-04-20 15:18 ` Gujjar, Abhinandan S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ea61576-9124-266a-00e6-cb9f22a37f59@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=abhinandan.gujjar@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=narender.vangati@intel.com \
--cc=nikhil.rao@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).