From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Declan Doherty <declan.doherty@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Olivier Matz <olivier.matz@6wind.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Jianfeng Tan <jianfeng.tan@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib: clear experimental version tag in linker scripts
Date: Fri, 27 Apr 2018 16:55:20 +0100 [thread overview]
Message-ID: <5f87cc42-4254-8898-e1ac-da5412fc93f7@intel.com> (raw)
In-Reply-To: <20180427154227.GB22078@hmswarspite.think-freely.org>
On 4/27/2018 4:42 PM, Neil Horman wrote:
> On Fri, Apr 27, 2018 at 04:17:55PM +0100, Ferruh Yigit wrote:
>> Remove version tag from experimental block in linker version scripts
>> (.map files).
>>
>> That label is not used by linker and information only. It is useful
>> for version blocks but not useful for experimental block but confusing.
>> Removing those labels.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: Neil Horman <nhorman@tuxdriver.com>
>> Cc: Thomas Monjalon <thomas@monjalon.net>
>> ---
>> drivers/net/dpaa/rte_pmd_dpaa_version.map | 4 +---
>> lib/librte_cryptodev/rte_cryptodev_version.map | 2 +-
>> lib/librte_eal/rte_eal_version.map | 2 +-
>> lib/librte_ethdev/rte_ethdev_version.map | 2 +-
>> lib/librte_eventdev/rte_eventdev_version.map | 2 +-
>> lib/librte_mbuf/rte_mbuf_version.map | 3 +--
>> lib/librte_mempool/rte_mempool_version.map | 3 +--
>> lib/librte_meter/rte_meter_version.map | 2 +-
>> lib/librte_net/rte_net_version.map | 2 +-
>> lib/librte_pipeline/rte_pipeline_version.map | 2 +-
>> lib/librte_vhost/rte_vhost_version.map | 2 +-
>> 11 files changed, 11 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/net/dpaa/rte_pmd_dpaa_version.map b/drivers/net/dpaa/rte_pmd_dpaa_version.map
>> index 3b937b10f..c7ad4030a 100644
>> --- a/drivers/net/dpaa/rte_pmd_dpaa_version.map
>> +++ b/drivers/net/dpaa/rte_pmd_dpaa_version.map
>> @@ -9,6 +9,4 @@ EXPERIMENTAL {
>> dpaa_eth_eventq_attach;
>> dpaa_eth_eventq_detach;
>> rte_pmd_dpaa_set_tx_loopback;
>> -
>> - local: *;
> Are you sure you meant to remove this local tag?
Yes, it was a duplicate, above DPDK_17.11 one has it already.
>
> Everything else looks good
>
> Neil
>
next prev parent reply other threads:[~2018-04-27 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 15:17 Ferruh Yigit
2018-04-27 15:42 ` Neil Horman
2018-04-27 15:55 ` Ferruh Yigit [this message]
2018-04-27 19:30 ` Neil Horman
2018-05-14 1:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f87cc42-4254-8898-e1ac-da5412fc93f7@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=shreyansh.jain@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).