From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Stephen Hurd <stephen.hurd@broadcom.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Declan Doherty <declan.doherty@intel.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Helin Zhang <helin.zhang@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pascal Mazon <pascal.mazon@6wind.com>,
Shrikrishna Khare <skhare@vmware.com>,
Jianfeng Tan <jianfeng.tan@intel.com>,
Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org>,
Gaetan Rivet <gaetan.rivet@6wind.com>,
Jan Blunck <jblunck@infradead.org>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: remove driver name from device private data
Date: Wed, 7 Jun 2017 10:22:42 +0530 [thread overview]
Message-ID: <5f9f3914-ab05-11a7-2fe5-1eb143c47f90@nxp.com> (raw)
In-Reply-To: <20170606151008.62680-1-ferruh.yigit@intel.com>
On Tuesday 06 June 2017 08:40 PM, Ferruh Yigit wrote:
> rte_driver->name has the driver name and all physical and virtual
> devices has access to it.
>
> Previously it was not possible for virtual ethernet devices to access
> rte_driver->name field (because eth_dev used to keep only pci_dev),
> and it was required to save driver name in the device private struct.
>
> After re-works on bus and vdev, it is possible for all bus types to
> access rte_driver.
>
> It is able to remove the driver name from ethdev device private data and
> use eth_dev->device->driver->name.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
> Cc: Jan Blunck <jblunck@infradead.org>
>
> v2:
> * rebase on latest next-net
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
> drivers/net/bonding/rte_eth_bond_api.c | 4 ++--
> drivers/net/cxgbe/sge.c | 6 +++---
> drivers/net/dpaa2/dpaa2_ethdev.c | 1 -
> drivers/net/i40e/i40e_ethdev.c | 3 +--
> drivers/net/i40e/i40e_fdir.c | 2 +-
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
> drivers/net/ring/rte_eth_ring.c | 1 -
> drivers/net/tap/rte_eth_tap.c | 1 -
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
> drivers/net/xenvirt/rte_eth_xenvirt.c | 1 -
> lib/librte_ether/rte_ethdev.c | 8 ++++----
> lib/librte_ether/rte_ethdev.h | 1 -
> lib/librte_ether/rte_ethdev_pci.h | 1 -
> lib/librte_ether/rte_ethdev_vdev.h | 1 -
> 15 files changed, 14 insertions(+), 22 deletions(-)
>
Apologies for delay in responding. I am OK with respect to the dpaa2
change. Otherwise as well:
Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
next prev parent reply other threads:[~2017-06-07 4:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 11:15 [dpdk-dev] [PATCH] " Ferruh Yigit
2017-06-06 15:10 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2017-06-06 15:31 ` Gaëtan Rivet
2017-06-07 4:52 ` Shreyansh Jain [this message]
2017-06-07 16:11 ` Jan Blunck
2017-06-09 14:22 ` Ferruh Yigit
2017-06-09 15:49 ` Ferruh Yigit
2017-06-08 20:58 ` Thomas Monjalon
2017-06-09 10:51 ` Ferruh Yigit
2017-06-09 17:51 ` [dpdk-dev] [PATCH v3 1/3] net/ring: set ethernet device field Ferruh Yigit
2017-06-09 17:51 ` [dpdk-dev] [PATCH v3 2/3] net/ring: create vdev from PMD specific API Ferruh Yigit
2017-06-12 13:25 ` Bruce Richardson
2017-06-12 14:08 ` Ferruh Yigit
2017-06-12 14:19 ` Bruce Richardson
2017-06-12 14:38 ` Ferruh Yigit
2017-06-09 17:51 ` [dpdk-dev] [PATCH v3 3/3] ethdev: remove driver name from device private data Ferruh Yigit
2017-06-12 14:13 ` [dpdk-dev] [PATCH v4 1/3] net/ring: set ethernet device field Ferruh Yigit
2017-06-12 14:13 ` [dpdk-dev] [PATCH v4 2/3] net/ring: use EAL APIs in PMD specific API Ferruh Yigit
2017-06-12 14:20 ` Bruce Richardson
2017-06-12 14:13 ` [dpdk-dev] [PATCH v4 3/3] ethdev: remove driver name from device private data Ferruh Yigit
2017-06-12 15:25 ` [dpdk-dev] [PATCH v5 1/3] net/ring: set ethernet device field Ferruh Yigit
2017-06-12 15:25 ` [dpdk-dev] [PATCH v5 2/3] net/ring: use EAL APIs in PMD specific API Ferruh Yigit
2017-06-12 15:25 ` [dpdk-dev] [PATCH v5 3/3] ethdev: remove driver name from device private data Ferruh Yigit
2017-06-12 15:37 ` [dpdk-dev] [PATCH v5 1/3] net/ring: set ethernet device field Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f9f3914-ab05-11a7-2fe5-1eb143c47f90@nxp.com \
--to=shreyansh.jain@nxp.com \
--cc=ajit.khaparde@broadcom.com \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=helin.zhang@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jblunck@infradead.org \
--cc=jianfeng.tan@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=pascal.mazon@6wind.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=skhare@vmware.com \
--cc=stephen.hurd@broadcom.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).