From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Scott Branden <scott.branden@broadcom.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
dev@dpdk.org
Cc: Darren Edamura <darren.edamura@broadcom.com>,
Rahul Gupta <rahul.gupta@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH 4/4] igb_uio: bind error if pcie bridge
Date: Mon, 26 Mar 2018 19:20:55 +0100 [thread overview]
Message-ID: <5fa0e9d9-9c64-c1e8-423d-e9d4441d5b3c@intel.com> (raw)
In-Reply-To: <f59f25bc-9cb6-5ad7-5921-d616ebadc2ec@broadcom.com>
On 3/26/2018 7:05 PM, Scott Branden wrote:
> Hi Ferruh,
>
>
> On 18-03-26 10:24 AM, Ferruh Yigit wrote:
>> On 3/21/2018 6:06 PM, Ajit Khaparde wrote:
>>> From: Darren Edamura <darren.edamura@broadcom.com>
>>>
>>> Probe function should exit immediately if pcie bridge detected
>>>
>>> Signed-off-by: Darren Edamura <darren.edamura@broadcom.com>
>>> Signed-off-by: Rahul Gupta <rahul.gupta@broadcom.com>
>>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>>> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>>> ---
>>> lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>>> index 4cae4dd27..3fabbfc4d 100644
>>> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>>> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>>> @@ -473,6 +473,9 @@ igbuio_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>>> void *map_addr;
>>> int err;
>>>
>>> + if (pci_is_bridge(dev))
>>> + return -ENODEV;
>> What do you think printing a log here?
> I think it brings little value. ENODEV is already returned?
User should not provide bridge address at first place, I guess this is a
protection in case user provides bridge address by mistake.
In that case no device will be probed and user won't have any idea why.
I think a log in dmesg saying bridge device is provided may help to the user.
>>
>>> +
>>> udev = kzalloc(sizeof(struct rte_uio_pci_dev), GFP_KERNEL);
>>> if (!udev)
>>> return -ENOMEM;
>>>
> Regards,
> Scott
>
next prev parent reply other threads:[~2018-03-26 18:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 18:06 [dpdk-dev] [PATCH 0/4] bnxt patchset Ajit Khaparde
2018-03-21 18:06 ` [dpdk-dev] [PATCH 1/4] introduce Broadcom Stingray Ajit Khaparde
2018-03-30 10:34 ` Ferruh Yigit
2018-03-30 18:54 ` Scott Branden
2018-03-21 18:06 ` [dpdk-dev] [PATCH 2/4] net/bnxt: add support for Stingray PF devices ids Ajit Khaparde
2018-03-30 10:35 ` Ferruh Yigit
2018-03-30 18:24 ` Scott Branden
2018-04-10 0:20 ` [dpdk-dev] [PATCH v4 0/3] bnxt patchset to support Stingray product family Ajit Khaparde
2018-04-10 0:20 ` [dpdk-dev] [PATCH v4 1/3] introduce Broadcom Stingray Ajit Khaparde
2018-04-10 0:20 ` [dpdk-dev] [PATCH v4 2/3] net/bnxt: add support for Stingray PF devices ids Ajit Khaparde
2018-04-10 0:20 ` [dpdk-dev] [PATCH v4 3/3] doc: add Broadcom Stingray SoC support to release notes Ajit Khaparde
2018-04-11 19:07 ` Ferruh Yigit
2018-04-13 21:07 ` [dpdk-dev] [PATCH v5 1/3] introduce Broadcom Stingray Ajit Khaparde
2018-04-13 21:07 ` [dpdk-dev] [PATCH v5 2/3] net/bnxt: add support for Stingray PF devices ids Ajit Khaparde
2018-04-13 21:07 ` [dpdk-dev] [PATCH v5 3/3] doc: add Broadcom Stingray SoC support to release notes Ajit Khaparde
2018-04-13 23:07 ` [dpdk-dev] [PATCH v5 1/3] introduce Broadcom Stingray Ferruh Yigit
2018-03-21 18:06 ` [dpdk-dev] [PATCH 3/4] mk: allow kernel artifacts to be located in output directory Ajit Khaparde
2018-03-30 10:35 ` Ferruh Yigit
2018-03-30 18:23 ` Scott Branden
2018-04-03 14:18 ` Ferruh Yigit
[not found] ` <CACZ4nhuwOp99YiaD75TzQ1igPgnjsayqHLnXyaNmmpySVZefPA@mail.gmail.com>
2018-04-06 18:10 ` Scott Branden
2018-04-06 21:31 ` Ferruh Yigit
2018-04-06 22:32 ` Scott Branden
2018-04-10 14:59 ` Ferruh Yigit
2018-04-10 20:30 ` Scott Branden
2018-03-21 18:06 ` [dpdk-dev] [PATCH 4/4] igb_uio: bind error if pcie bridge Ajit Khaparde
2018-03-26 17:24 ` Ferruh Yigit
2018-03-26 18:05 ` Scott Branden
2018-03-26 18:20 ` Ferruh Yigit [this message]
2018-03-26 19:13 ` Scott Branden
2018-03-26 20:43 ` [dpdk-dev] [PATCH v2] " Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fa0e9d9-9c64-c1e8-423d-e9d4441d5b3c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=darren.edamura@broadcom.com \
--cc=dev@dpdk.org \
--cc=rahul.gupta@broadcom.com \
--cc=scott.branden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).