From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/9] redundant rte_vdev_driver declarations
Date: Mon, 15 Jul 2019 18:09:52 +0100 [thread overview]
Message-ID: <5fc15f1e-1416-6de2-6442-92487d4e9115@intel.com> (raw)
In-Reply-To: <bcd4af7a-e305-8a91-3362-37e4d7848893@intel.com>
On 7/15/2019 5:18 PM, Ferruh Yigit wrote:
> On 7/11/2019 9:03 PM, Stephen Hemminger wrote:
>> Many drivers declare the local rte_vdev_driver structure
>> multiple times. This is unnecessary.
>>
>> Surprised it is so common, I guess everyone copies the same code.
It seems it is common because a patchset explicitly added them [1] to set driver
name consistently, but later when another patch removed the related code [2] the
forward declarations seems forgotten to be removed.
I have updated commits to include the fixes lines so that they can be backported
(so that they don't cause additional conflicts for more serious patches in the
future.)
[1]: Fixes: 73db5badb042 ("net: align ethdev and eal driver names")
[2]: Fixes: 050fe6e9ff97 ("drivers/net: use ethdev allocation helper for vdev")
>>
>> Stephen Hemminger (9):
>> net/tap: remove redundant declarations
>> net/af_packet: remove redundant rte_vdev_driver declaration
>> net/vhost: remove redundant rte_vdev_driver declaration
>> net/null: remove redundant rte_vdev_driver declaration
>> net/pcap: remove redundant rte_vdev_driver declaration
>> net/ring: remove redundant rte_vdev_drive declaration
>> net/virtio_user: remove redundant rte_vdev_driver declaration
>> raw/skeleton_rawdev: remove redundant rte_vdev_driver declaration
>> raw/dpaa2_cmif: remove redundant rte_vdev_driver declaration
>
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Series applied to dpdk-next-net/master, thanks.
>
prev parent reply other threads:[~2019-07-15 17:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 20:03 Stephen Hemminger
2019-07-11 20:03 ` [dpdk-dev] [PATCH 1/9] net/tap: remove redundant declarations Stephen Hemminger
2019-07-11 21:29 ` Wiles, Keith
2019-07-11 20:03 ` [dpdk-dev] [PATCH 2/9] net/af_packet: remove redundant rte_vdev_driver declaration Stephen Hemminger
2019-07-11 20:03 ` [dpdk-dev] [PATCH 3/9] net/vhost: " Stephen Hemminger
2019-07-11 20:03 ` [dpdk-dev] [PATCH 4/9] net/null: " Stephen Hemminger
2019-07-11 20:03 ` [dpdk-dev] [PATCH 5/9] net/pcap: " Stephen Hemminger
2019-07-15 16:17 ` Ferruh Yigit
2019-07-11 20:03 ` [dpdk-dev] [PATCH 6/9] net/ring: remove redundant rte_vdev_drive declaration Stephen Hemminger
2019-07-12 8:31 ` Bruce Richardson
2019-07-11 20:03 ` [dpdk-dev] [PATCH 7/9] net/virtio_user: remove redundant rte_vdev_driver declaration Stephen Hemminger
2019-07-11 20:03 ` [dpdk-dev] [PATCH 8/9] raw/skeleton_rawdev: " Stephen Hemminger
2019-07-11 20:03 ` [dpdk-dev] [PATCH 9/9] raw/dpaa2_cmif: " Stephen Hemminger
2019-07-15 16:18 ` [dpdk-dev] [PATCH 0/9] redundant rte_vdev_driver declarations Ferruh Yigit
2019-07-15 17:09 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fc15f1e-1416-6de2-6442-92487d4e9115@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).