From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] devtools: make log checking script BSD-compatible
Date: Mon, 27 Mar 2017 23:45:01 +0200 [thread overview]
Message-ID: <6088978.UBRGF4N90V@xps13> (raw)
In-Reply-To: <20170323150926.16818-1-bruce.richardson@intel.com>
2017-03-23 15:09, Bruce Richardson:
> The -e flag to readlink doesn't exist on FreeBSD so change it to -f instead
> which is present on both BSD and Linux. Error reported is:
>
> readlink: illegal option -- e
> usage: readlink [-fn] [file ...]
> usage: dirname string [...]
> ./devtools/check-git-log.sh: /git-log-fixes.sh: not found
>
> Fixes: 814c8822ef7b ("scripts: check cc stable mailing list in commit")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
[...]
> -selfdir=$(dirname $(readlink -e $0))
> +selfdir=$(dirname $(readlink -f $0))
You win the prize of the shortest fix with only one letter! :)
Applied, thanks
prev parent reply other threads:[~2017-03-27 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 15:09 Bruce Richardson
2017-03-27 21:45 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6088978.UBRGF4N90V@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).