From: "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>
To: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>,
"Liang, Cunming" <cunming.liang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] test/pmd_perf: fix for segmentation fault
Date: Tue, 31 Oct 2017 09:14:50 +0000 [thread overview]
Message-ID: <60ABE07DBB3A454EB7FAD707B4BB158213C4BCE1@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <20171027162408.90288-1-danielx.t.mrzyglod@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Daniel Mrzyglod
> Sent: Friday, October 27, 2017 6:24 PM
> To: dev@dpdk.org
> Cc: Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>; Liang, Cunming
> <cunming.liang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] test/pmd_perf: fix for segmentation fault
>
> Error can be reproduce if we run pmd_perf_autotest with more then
> one device in such way:
> RTE>>set_rxtx_sc poll_before_xmit
> RTE>>pmd_perf_autotest
>
> if first burst was value less than MAX_PKT_BURST in the end we overwrite
> pkts_burst table for rx which was supposed for another interface.
>
> Fixes: 002ade70e933 ("app/test: measure cycles per packet in Rx/Tx")
> Cc: cunming.liang@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
> test/test/test_pmd_perf.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/test/test/test_pmd_perf.c b/test/test/test_pmd_perf.c
> index a3e29ed..255f260 100644
> --- a/test/test/test_pmd_perf.c
> +++ b/test/test/test_pmd_perf.c
> @@ -572,6 +572,7 @@ poll_burst(void *args)
> unsigned i, portid, nb_rx = 0;
> uint64_t total;
> uint64_t timeout = MAX_IDLE;
> + int num[RTE_MAX_ETHPORTS];
>
> lcore_id = rte_lcore_id();
> conf = &lcore_conf[lcore_id];
> @@ -591,6 +592,7 @@ poll_burst(void *args)
> for (i = 0; i < conf->nb_ports; i++) {
> portid = conf->portlist[i];
> next[portid] = i * pkt_per_port;
> + num[portid] = pkt_per_port;
> }
>
> while (!rte_atomic64_read(&start))
> @@ -601,8 +603,8 @@ poll_burst(void *args)
> for (i = 0; i < conf->nb_ports; i++) {
> portid = conf->portlist[i];
> nb_rx = rte_eth_rx_burst(portid, 0,
> - &pkts_burst[next[portid]],
> - MAX_PKT_BURST);
> + &pkts_burst[next[portid]],
> + RTE_MIN(MAX_PKT_BURST,
> num[portid]));
> if (unlikely(nb_rx == 0)) {
> timeout--;
> if (unlikely(timeout == 0))
> @@ -610,6 +612,7 @@ poll_burst(void *args)
> continue;
> }
> next[portid] += nb_rx;
> + num[portid] -= nb_rx;
> total -= nb_rx;
> }
> }
> @@ -618,7 +621,6 @@ poll_burst(void *args)
>
> printf("%"PRIu64" packets lost, IDLE %"PRIu64" times\n",
> total, MAX_IDLE - timeout);
> -
> /* clean up */
> total = pkt_per_port * conf->nb_ports - total;
> for (i = 0; i < total; i++)
> @@ -644,7 +646,7 @@ exec_burst(uint32_t flags, int lcore)
> conf = &lcore_conf[lcore];
>
> pkt_per_port = MAX_TRAFFIC_BURST;
> - num = pkt_per_port;
> + num = pkt_per_port * conf->nb_ports;
>
> rte_atomic64_init(&start);
>
> @@ -661,11 +663,12 @@ exec_burst(uint32_t flags, int lcore)
> nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> for (i = 0; i < conf->nb_ports; i++) {
> portid = conf->portlist[i];
> - rte_eth_tx_burst(portid, 0,
> + nb_tx = rte_eth_tx_burst(portid, 0,
> &tx_burst[idx], nb_tx);
> idx += nb_tx;
> + num -= nb_tx;
> }
> - num -= nb_tx;
> +
> }
>
> sleep(5);
> --
> 2.7.4
Acked-by: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
next prev parent reply other threads:[~2017-10-31 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 14:20 [dpdk-stable] [PATCH] " Michal Jastrzebski
2017-10-27 16:24 ` [dpdk-stable] [PATCH v2] " Daniel Mrzyglod
2017-10-31 9:14 ` Jastrzebski, MichalX K [this message]
2017-11-07 16:56 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ABE07DBB3A454EB7FAD707B4BB158213C4BCE1@IRSMSX109.ger.corp.intel.com \
--to=michalx.k.jastrzebski@intel.com \
--cc=cunming.liang@intel.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).