From: "Wiles, Keith" <keith.wiles@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/9] net/tap: remove redundant declarations
Date: Thu, 11 Jul 2019 21:29:56 +0000 [thread overview]
Message-ID: <60BCF770-6C7E-44AD-83D6-D9544D8DF8A6@intel.com> (raw)
In-Reply-To: <20190711200309.6134-2-stephen@networkplumber.org>
> On Jul 11, 2019, at 3:03 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> The rte_vdev_drivers are declared twice.
> The first one is not necessary.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/tap/rte_eth_tap.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 3841842f01f8..64bd049110e1 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -71,8 +71,6 @@
> #define TAP_IOV_DEFAULT_MAX 1024
>
> static int tap_devices_count;
> -static struct rte_vdev_driver pmd_tap_drv;
> -static struct rte_vdev_driver pmd_tun_drv;
>
> static const char *valid_arguments[] = {
> ETH_TAP_IFACE_ARG,
> --
> 2.20.1
>
Acked-by: Keith Wiles <keith.wiles@intel.com>
Regards,
Keith
next prev parent reply other threads:[~2019-07-11 21:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 20:03 [dpdk-dev] [PATCH 0/9] redundant rte_vdev_driver declarations Stephen Hemminger
2019-07-11 20:03 ` [dpdk-dev] [PATCH 1/9] net/tap: remove redundant declarations Stephen Hemminger
2019-07-11 21:29 ` Wiles, Keith [this message]
2019-07-11 20:03 ` [dpdk-dev] [PATCH 2/9] net/af_packet: remove redundant rte_vdev_driver declaration Stephen Hemminger
2019-07-11 20:03 ` [dpdk-dev] [PATCH 3/9] net/vhost: " Stephen Hemminger
2019-07-11 20:03 ` [dpdk-dev] [PATCH 4/9] net/null: " Stephen Hemminger
2019-07-11 20:03 ` [dpdk-dev] [PATCH 5/9] net/pcap: " Stephen Hemminger
2019-07-15 16:17 ` Ferruh Yigit
2019-07-11 20:03 ` [dpdk-dev] [PATCH 6/9] net/ring: remove redundant rte_vdev_drive declaration Stephen Hemminger
2019-07-12 8:31 ` Bruce Richardson
2019-07-11 20:03 ` [dpdk-dev] [PATCH 7/9] net/virtio_user: remove redundant rte_vdev_driver declaration Stephen Hemminger
2019-07-11 20:03 ` [dpdk-dev] [PATCH 8/9] raw/skeleton_rawdev: " Stephen Hemminger
2019-07-11 20:03 ` [dpdk-dev] [PATCH 9/9] raw/dpaa2_cmif: " Stephen Hemminger
2019-07-15 16:18 ` [dpdk-dev] [PATCH 0/9] redundant rte_vdev_driver declarations Ferruh Yigit
2019-07-15 17:09 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60BCF770-6C7E-44AD-83D6-D9544D8DF8A6@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).