From: Thomas Monjalon <thomas@monjalon.net>
To: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>
Cc: Jerin Jacob <jerinjacobk@gmail.com>,
stable@dpdk.org, "jerinj@marvell.com" <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
"sthotton@marvell.com" <sthotton@marvell.com>
Subject: Re: [PATCH v7 2/3] timer: fix function to stop all timers
Date: Wed, 05 Oct 2022 14:59:44 +0200 [thread overview]
Message-ID: <6100135.17fYzF0512@thomas> (raw)
In-Reply-To: <DM6PR11MB386844370D6E4C131BB91D2EA1489@DM6PR11MB3868.namprd11.prod.outlook.com>
> > On Wed, Sep 14, 2022 at 9:03 PM Naga Harish K S V
> > <s.v.naga.harish.k@intel.com> wrote:
> > >
> > > There is a possibility of deadlock in this API, as same spinlock is
> > > tried to be acquired in nested manner.
> > >
> > > If the lcore that is stopping the timer is different from the lcore
> > > that owns the timer, the timer list lock is acquired in timer_del(),
> > > even if local_is_locked is true. Because the same lock was already
> > > acquired in rte_timer_stop_all(), the thread will hang.
> > >
> > > This patch removes the acquisition of nested lock.
> > >
> > > Fixes: 821c51267bcd63a ("timer: add function to stop all timers in a
> > > list")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
>
> Added missing ack
Applied, thanks.
next prev parent reply other threads:[~2022-10-05 12:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220812160714.287055-1-s.v.naga.harish.k@intel.com>
[not found] ` <20220914050855.1677489-1-s.v.naga.harish.k@intel.com>
2022-09-14 5:08 ` [PATCH v5 2/4] " Naga Harish K S V
[not found] ` <20220914051541.1678837-1-s.v.naga.harish.k@intel.com>
2022-09-14 5:15 ` Naga Harish K S V
[not found] ` <20220914135147.1846550-1-s.v.naga.harish.k@intel.com>
2022-09-14 13:51 ` [PATCH v6 2/3] " Naga Harish K S V
[not found] ` <20220914153319.1887248-1-s.v.naga.harish.k@intel.com>
2022-09-14 15:33 ` [PATCH v7 " Naga Harish K S V
2022-09-15 6:41 ` Jerin Jacob
2022-09-16 4:40 ` Naga Harish K, S V
2022-10-05 12:59 ` Thomas Monjalon [this message]
2022-09-26 5:21 ` Naga Harish K, S V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6100135.17fYzF0512@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=pbhagavatula@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
--cc=stable@dpdk.org \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).