From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Patil, Harish" <Harish.Patil@cavium.com>,
"Mody, Rasesh" <Rasesh.Mody@cavium.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
Cc: Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option
Date: Thu, 9 Nov 2017 17:07:09 -0800 [thread overview]
Message-ID: <61535b92-3315-2737-8112-4fe65d291c02@intel.com> (raw)
In-Reply-To: <D62A2043.1739F8%Harish.Patil@cavium.com>
On 11/9/2017 3:16 PM, Patil, Harish wrote:
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Date: Thursday, November 9, 2017 at 4:07 PM
> To: Harish Patil <Harish.Patil@cavium.com>, "Mody, Rasesh"
> <Rasesh.Mody@cavium.com>, "dev@dpdk.org" <dev@dpdk.org>,
> "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
> Cc: Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>
> Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option
>
>> On 11/9/2017 3:00 PM, Patil, Harish wrote:
>>> -----Original Message-----
>>> From: Harish Patil <Harish.Patil@cavium.com>
>>> Date: Thursday, November 9, 2017 at 3:57 PM
>>> To: Ferruh Yigit <ferruh.yigit@intel.com>, "Mody, Rasesh"
>>> <Rasesh.Mody@cavium.com>, "dev@dpdk.org" <dev@dpdk.org>,
>>> "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
>>> Cc: Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>
>>> Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option
>>>
>>>> -----Original Message-----
>>>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>>>> Date: Thursday, November 9, 2017 at 3:48 PM
>>>> To: "Mody, Rasesh" <Rasesh.Mody@cavium.com>, "dev@dpdk.org"
>>>> <dev@dpdk.org>, "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
>>>> Cc: Harish Patil <Harish.Patil@cavium.com>, Dept-Eng DPDK Dev
>>>> <Dept-EngDPDKDev@cavium.com>
>>>> Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option
>>>>
>>>>> On 11/8/2017 10:52 PM, Rasesh Mody wrote:
>>>>>> From: Harish Patil <harish.patil@cavium.com>
>>>>>>
>>>>>> Restore the default configuration as in previous releases and
>>>>>> add a debug msg.
>>>>>
>>>>> Is this reverting
>>>>> "f07aa795c92a ("net/qede: disable per-VF Tx switching feature")"
>>>>>
>>>>> This will be same as code before f07aa795c92a , right? If so why not
>>>>> just
>>>>> remove
>>>>> the config option for this release and add a dynamic runtime in next
>>>>> release?
>>>>>
>>>>> I am not clear for both f07aa795c92a and this one fixing, and why
>>>>> should
>>>>> they be
>>>>> included for rc3?
>>>>>
>>>>> Thanks,
>>>>> Ferruh
>>>>
>>>> Hi Ferruh,
>>>> Some customers are interested in getting better performance with 64B
>>>> sized
>>>> packets. For that, they would need to keep this config disabled.
>>>> But in all other cases, by default, we would like to keep Tx switching
>>>> enabled (at a reduced performance) as in previous releases.
>>>> As stated in other email with Thomas, we shall remove this compile-time
>>>> config option in next release and use runtime option instead.
>>>> But for 17.08 we need it to be enabled by default.
>>>> Thanks.
>>>
>>> Correction, I meant 17.11 release, not 17.08.
>>
>> Other patch just sent two days ago, to introduce the config option as
>> disabled
>> by default, so it was changing the behavior and accepted as a fix for rc3.
>>
>> Now two days later, this patch enables it as a fix again, only difference
>> for
>> two days ago becomes adding a config option?
>>
>
> Hi Ferruh,
> The patch sent two days ago with config option disabled was a mistake.
> Yesterday we realized that it is not a desirable thing to keep the config
> disabled since many customers would typically need Tx switching to be
> enabled.
I am trying to say, if you want to revert back and turn to original code, why
not completely revert, removing config option too?
Specially taking into account that you will remove it next release already.
> So the current patch we sent is just to change back the config option set
> to enable from disable. Hence its a fix for the previous patch.
The cumulative output of both patches are adding a config option that doesn't
change code execution by default. Overall output is not a fix.
What do you think about a full revert of previous patch?
> Thanks.
>>>>
>>>>>
>>>>>>
>>>>>> Fixes: f07aa795c92a ("net/qede: disable per-VF Tx switching feature")
>>>>>>
>>>>>> Signed-off-by: Harish Patil <harish.patil@cavium.com>
>>>>>> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
>>>>>> ---
>>>>>> config/common_base | 2 +-
>>>>>> drivers/net/qede/qede_ethdev.c | 5 +++--
>>>>>> 2 files changed, 4 insertions(+), 3 deletions(-)
>>>>>>
>>>>>> diff --git a/config/common_base b/config/common_base
>>>>>> index 34f04a9..e74febe 100644
>>>>>> --- a/config/common_base
>>>>>> +++ b/config/common_base
>>>>>> @@ -415,7 +415,7 @@ CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n
>>>>>> CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=n
>>>>>> CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n
>>>>>> CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n
>>>>>> -CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n
>>>>>> +CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=y
>>>>>> #Provides abs path/name of the firmware file.
>>>>>> #Empty string denotes driver will use default firmware
>>>>>> CONFIG_RTE_LIBRTE_QEDE_FW=""
>>>>>> diff --git a/drivers/net/qede/qede_ethdev.c
>>>>>> b/drivers/net/qede/qede_ethdev.c
>>>>>> index 8832145..6f5ba2a 100644
>>>>>> --- a/drivers/net/qede/qede_ethdev.c
>>>>>> +++ b/drivers/net/qede/qede_ethdev.c
>>>>>> @@ -457,6 +457,7 @@ int qede_activate_vport(struct rte_eth_dev
>>>>>> *eth_dev, bool flg)
>>>>>> if (IS_VF(edev)) {
>>>>>> params.update_tx_switching_flg = 1;
>>>>>> params.tx_switching_flg = !flg;
>>>>>> + DP_INFO(edev, "VF tx-switching is disabled\n");
>>>>>> }
>>>>>> #endif
>>>>>> for_each_hwfn(edev, i) {
>>>>>> @@ -469,8 +470,8 @@ int qede_activate_vport(struct rte_eth_dev
>>>>>> *eth_dev, bool flg)
>>>>>> break;
>>>>>> }
>>>>>> }
>>>>>> - DP_INFO(edev, "vport %s VF tx-switch %s\n", flg ? "activated" :
>>>>>> "deactivated",
>>>>>> - params.tx_switching_flg ? "enabled" : "disabled");
>>>>>> + DP_INFO(edev, "vport is %s\n", flg ? "activated" : "deactivated");
>>>>>> +
>>>>>> return rc;
>>>>>> }
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
next prev parent reply other threads:[~2017-11-10 1:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 6:52 [dpdk-dev] [PATCH 1/2] doc: update QEDE pmd nic guide Rasesh Mody
2017-11-09 6:52 ` [dpdk-dev] [PATCH 2/2] net/qede: fix default config option Rasesh Mody
2017-11-09 22:48 ` Ferruh Yigit
2017-11-09 22:57 ` Patil, Harish
2017-11-09 23:00 ` Patil, Harish
2017-11-09 23:07 ` Ferruh Yigit
2017-11-09 23:16 ` Patil, Harish
2017-11-10 1:07 ` Ferruh Yigit [this message]
2017-11-10 1:53 ` Mody, Rasesh
2017-11-10 2:03 ` Ferruh Yigit
2017-11-10 8:24 ` [dpdk-dev] [PATCH 1/2] doc: update QEDE pmd nic guide Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61535b92-3315-2737-8112-4fe65d291c02@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=Harish.Patil@cavium.com \
--cc=Rasesh.Mody@cavium.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).