From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/load_balancer: enable the build for lesser lcores
Date: Wed, 19 Jul 2017 13:27:49 +0530 [thread overview]
Message-ID: <616bec5e-b312-c72e-2be2-e0013528c416@nxp.com> (raw)
In-Reply-To: <1782606.ZZX3YYOCMi@xps>
On 7/19/2017 10:51 AM, Thomas Monjalon wrote:
> 17/07/2017 11:41, Hemant Agrawal:
>> --- a/examples/load_balancer/main.h
>> +++ b/examples/load_balancer/main.h
>> #ifndef APP_MAX_IO_LCORES
>> +#if (APP_MAX_LCORES > 16)
>> #define APP_MAX_IO_LCORES 16
>> +#else
>> +#define APP_MAX_IO_LCORES APP_MAX_LCORES
>> #endif
>> -#if (APP_MAX_IO_LCORES > APP_MAX_LCORES)
>> -#error "APP_MAX_IO_LCORES is too big"
>> #endif
> [...]
>> #ifndef APP_MAX_WORKER_LCORES
>> +#if (APP_MAX_LCORES > 16)
>> #define APP_MAX_WORKER_LCORES 16
>> +#else
>> +#define APP_MAX_WORKER_LCORES APP_MAX_LCORES
>> #endif
>> -#if (APP_MAX_WORKER_LCORES > APP_MAX_LCORES)
>> -#error "APP_MAX_WORKER_LCORES is too big"
>> #endif
>
> Why removing the checks > APP_MAX_LCORES ?
>
It is not going to be needed unless someone defines it.
I will send v2 with reverting them back.
next prev parent reply other threads:[~2017-07-19 7:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 8:41 Hemant Agrawal
2017-07-19 5:21 ` Thomas Monjalon
2017-07-19 7:57 ` Hemant Agrawal [this message]
2017-07-19 8:19 ` [dpdk-dev] [PATCH v2] " Hemant Agrawal
2017-07-21 14:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=616bec5e-b312-c72e-2be2-e0013528c416@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).