From: "Bourke, Euan" <euan.bourke@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH v2 1/2] doc: updated incorrect value for IP frag max fragments
Date: Thu, 21 Dec 2023 13:46:29 +0000 [thread overview]
Message-ID: <6174a29e-8182-4465-8872-b441221b815f@intel.com> (raw)
In-Reply-To: <3099751.jZfb76A358@thomas>
On 21/12/2023 11:41, Thomas Monjalon wrote:
> 21/12/2023 12:32, Euan Bourke:
>> -/* ip_fragmentation defines */
>> +/* ip_fragmentation defines 8< */
>> #define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8
>> +/* >8 End of ip_fragmentation defines */
> [...]
>> +.. literalinclude:: ../../../config/rte_config.h
>> + :start-after: ip_fragmentation defines 8<
>> + :end-before: >8 End of ip_fragmentation defines
>
> In v1 I asked to use "start-at". You didn't reply.
> It is more convenient for a one-line include.
> Don't you agree?
>
>
Apologies, as I was updating the name of the declare in the next patch,
I thought this way would be better, will use "start-at" in next version.
next prev parent reply other threads:[~2023-12-21 13:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <https://inbox.dpdk.org/dev/20231219151754.3285058-1-euan.bourke@intel.com/>
2023-12-21 11:32 ` Euan Bourke
2023-12-21 11:32 ` [PATCH v2 2/2] ip_frag: updated name for IP frag define Euan Bourke
2023-12-21 11:39 ` [PATCH v2 1/2] doc: updated incorrect value for IP frag max fragments David Marchand
2023-12-21 11:41 ` Thomas Monjalon
2023-12-21 13:46 ` Bourke, Euan [this message]
2023-12-21 17:41 ` [PATCH v3 " Euan Bourke
2023-12-21 17:41 ` [PATCH v3 2/2] ip_frag: updated name for IP frag max frag define Euan Bourke
2023-12-22 9:08 ` Bruce Richardson
2024-01-08 11:36 ` [PATCH v4 1/2] doc: updated incorrect value for IP frag max fragments Euan Bourke
2024-01-08 11:36 ` [PATCH v4 2/2] ip_frag: updated name for IP frag define Euan Bourke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6174a29e-8182-4465-8872-b441221b815f@intel.com \
--to=euan.bourke@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).