From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
anatoly.burakov@intel.comm, xiao.w.wang@intel.com,
junjie.j.chen@intel.com
Subject: Re: [dpdk-dev] [PATCH] eal/vfio: export internal vfio functions
Date: Tue, 3 Apr 2018 11:57:40 +0530 [thread overview]
Message-ID: <61905017-5c93-87f7-032d-e0b1907f56c0@nxp.com> (raw)
In-Reply-To: <1882630.IHjtNmfOsM@xps>
Hi Thomas,
On 3/27/2018 9:23 PM, Thomas Monjalon wrote:
> 14/03/2018 09:00, Hemant Agrawal:
>> This patch moves some of the internal vfio functions from
>> eal_vfio.h to rte_vfio.h for common uses with "rte_" prefix.
>>
>> This patch also change the FSLMC bus usages from the internal
>> VFIO functions to external ones with "rte_" prefix
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>> --- a/lib/librte_eal/common/include/rte_vfio.h
>> +++ b/lib/librte_eal/common/include/rte_vfio.h
>> @@ -28,6 +28,12 @@
>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 5, 0)
>> +#define RTE_VFIO_NOIOMMU 8
>> +#else
>> +#define RTE_VFIO_NOIOMMU VFIO_NOIOMMU_IOMMU
>> +#endif
> I know this is just a move of an existing code,
> but do you know why this check is against a version number (4.5.0),
> instead of #ifdef VFIO_NOIOMMU_IOMMU which would be backport-safe?
Agreed. please check it in v3.
>> +/**
>> + * Parse IOMMU group number for a device
>> + *
>> + * This function is only relevant to linux and will return
>> + * an error on BSD.
>> + *
>> + * @return
>> + * 1 on success
>> + * 0 for non-existent group
>> + * <0 for errors
>> + */
>> +int __rte_experimental
>> +rte_vfio_get_group_no(const char *sysfs_base,
>> + const char *dev_addr, int *iommu_group_no);
>> +
>> +/**
>> + * Open VFIO container fd or get an existing one
>> + *
>> + * This function is only relevant to linux and will return
>> + * an error on BSD.
>> + *
>> + * @return
>> + * > 0 container fd
>> + * < 0 for errors
>> + */
>> +int __rte_experimental
>> +rte_vfio_get_container_fd(void);
>> +
>> +/**
>> + * Open VFIO group fd or get an existing one
>> + *
>> + * This function is only relevant to linux and will return
>> + * an error on BSD.
>> + *
>> + * @return
>> + * > 0 group fd
>> + * < 0 for errors
>> + */
>> +int __rte_experimental
>> +rte_vfio_get_group_fd(int iommu_group_no);
> All these new functions should have some @param documentation.
added the @param
> This file is not included in doxygen, probably because @file is missing.
most of these functions are internal functions. do you think we should
add it in doxygen as well?
>
> About the naming, are you sure about "group_no" instead of "group_num"?
Agree, but this is already in many places. I feel this change will be
unnecessary.
>
>> --- a/lib/librte_eal/rte_eal_version.map
>> +++ b/lib/librte_eal/rte_eal_version.map
>> @@ -254,5 +254,8 @@ EXPERIMENTAL {
>> rte_service_set_runstate_mapped_check;
>> rte_service_set_stats_enable;
>> rte_service_start_with_defaults;
>> + rte_vfio_get_group_no;
>> + rte_vfio_get_container_fd;
>> + rte_vfio_get_group_fd;
> Please indent with tabs.
>
>
done in v3
next prev parent reply other threads:[~2018-04-03 6:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 8:00 Hemant Agrawal
2018-03-14 10:19 ` Burakov, Anatoly
2018-03-27 15:53 ` Thomas Monjalon
2018-04-03 6:27 ` Hemant Agrawal [this message]
2018-04-03 7:34 ` Thomas Monjalon
2018-04-03 8:34 ` Hemant Agrawal
2018-04-02 8:36 ` [dpdk-dev] [PATCH v2] " Hemant Agrawal
2018-04-02 16:41 ` Thomas Monjalon
2018-04-03 8:28 ` [dpdk-dev] [PATCH v3 1/2] doc: add vfio api support Hemant Agrawal
2018-04-03 8:28 ` [dpdk-dev] [PATCH v3 2/2] eal/vfio: export internal vfio functions Hemant Agrawal
2018-04-03 10:16 ` [dpdk-dev] [PATCH v3 1/2] doc: add vfio api support Thomas Monjalon
2018-04-03 11:10 ` [dpdk-dev] [PATCH v4 " Hemant Agrawal
2018-04-03 11:10 ` [dpdk-dev] [PATCH v4 2/2] eal/vfio: export internal vfio functions Hemant Agrawal
2018-04-03 12:24 ` Thomas Monjalon
2018-04-03 12:59 ` Hemant Agrawal
2018-04-03 15:23 ` Wang, Xiao W
2018-04-04 6:47 ` Hemant Agrawal
2018-04-04 7:48 ` [dpdk-dev] [PATCH v5 1/2] doc: add vfio api support Hemant Agrawal
2018-04-04 7:48 ` [dpdk-dev] [PATCH v5 2/2] eal/vfio: export internal vfio functions Hemant Agrawal
2018-04-05 9:03 ` Wang, Xiao W
2018-04-05 10:22 ` Thomas Monjalon
2018-04-05 10:35 ` Wang, Xiao W
2018-04-11 21:25 ` Thomas Monjalon
2018-04-12 6:26 ` Hemant Agrawal
2018-04-12 6:23 ` [dpdk-dev] [PATCH v6 1/2] doc: add vfio api support Hemant Agrawal
2018-04-12 6:23 ` [dpdk-dev] [PATCH v6 2/2] eal/vfio: export internal vfio functions Hemant Agrawal
2018-04-12 23:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61905017-5c93-87f7-032d-e0b1907f56c0@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=anatoly.burakov@intel.comm \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=junjie.j.chen@intel.com \
--cc=thomas@monjalon.net \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).