patches for DPDK stable branches
 help / color / mirror / Atom feed

From: "OLoughlin, John" <john.oloughlin@intel.com>
To: "Morrissey, Sean" <sean.morrissey@intel.com>
Cc: "ciara.power@intel.com" <ciara.power@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg
Date: Thu, 11 Jul 2019 15:33:33 +0000	[thread overview]
Message-ID: <619A2585A61B984286AE439D7BFDAECE712C1573@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20190711144017.23081-1-sean.morrissey@intel.com>

Hi Seán,

Thanks for that
I can confirm that the patch is functionally correct

Regards John

-----Original Message-----
From: Morrissey, Sean 
Sent: Thursday, July 11, 2019 3:40 PM
To: OLoughlin, John <john.oloughlin@intel.com>
Cc: Morrissey, Sean <sean.morrissey@intel.com>; ciara.power@intel.com; stable@dpdk.org
Subject: [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg

Added telemetry to EAL long options so that when --telemetry is passed as an EAL arg that there is no unrecognized argument error message printed.

Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
Cc: ciara.power@intel.com
Cc: stable@dpdk.org

Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
---
 lib/librte_eal/common/eal_common_options.c | 3 +++
 lib/librte_eal/common/eal_options.h        | 8 +++++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 512d5088e..b7e511a63 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -80,6 +80,9 @@ eal_long_options[] = {
 	{OPT_VMWARE_TSC_MAP,    0, NULL, OPT_VMWARE_TSC_MAP_NUM   },
 	{OPT_LEGACY_MEM,        0, NULL, OPT_LEGACY_MEM_NUM       },
 	{OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM},
+#ifdef RTE_LIBRTE_TELEMETRY
+	{OPT_TELEMETRY,         0, NULL, OPT_TELEMETRY_NUM        },
+#endif
 	{OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},
 	{0,                     0, NULL, 0                        }
 };
diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h
index 9855429e5..f819845f5 100644
--- a/lib/librte_eal/common/eal_options.h
+++ b/lib/librte_eal/common/eal_options.h
@@ -67,9 +67,15 @@ enum {
 	OPT_SINGLE_FILE_SEGMENTS_NUM,
 #define OPT_IOVA_MODE          "iova-mode"
 	OPT_IOVA_MODE_NUM,
+
+#ifdef RTE_LIBRTE_TELEMETRY
+	#define OPT_TELEMETRY          "telemetry"
+		OPT_TELEMETRY_NUM,
+#endif
+
 #define OPT_MATCH_ALLOCATIONS  "match-allocations"
 	OPT_MATCH_ALLOCATIONS_NUM,
-	OPT_LONG_MAX_NUM
+	OPT_LONG_MAX_NUM,
 };
 
 extern const char eal_short_options[];
--
2.17.1

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.

next      parent reply	other threads:[~2019-07-11 15:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190711144017.23081-1-sean.morrissey@intel.com>
2019-07-11 15:33 ` OLoughlin, John [this message]
2019-07-15 10:54 Sean Morrissey
2019-07-19 10:04 ` Laatz, Kevin
2019-07-22 16:40   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=619A2585A61B984286AE439D7BFDAECE712C1573@IRSMSX101.ger.corp.intel.com \
    --to=john.oloughlin@intel.com \
    --cc=ciara.power@intel.com \
    --cc=sean.morrissey@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).