From: Thomas Monjalon <thomas@monjalon.net>
To: Brandon Lo <blo@iol.unh.edu>
Cc: "dpdklab@iol.unh.edu" <dpdklab@iol.unh.edu>,
"lylavoie@iol.unh.edu" <lylavoie@iol.unh.edu>,
Shijith Thotton <sthotton@marvell.com>,
Akhil Goyal <gakhil@marvell.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
dev <dev@dpdk.org>, "aconole@redhat.com" <aconole@redhat.com>,
ci@dpdk.org
Subject: Re: [dpdk-ci] [dpdk-dev] [PATCH] crypto/octeontx: enable build on non Linux OS
Date: Thu, 22 Jul 2021 22:32:58 +0200 [thread overview]
Message-ID: <6211865.m4nO5kPP42@thomas> (raw)
In-Reply-To: <CAOeXdvYn9mnOdad252AB8QR-CZG+QeXwbmw-GhG5QUDKhd-6QQ@mail.gmail.com>
22/07/2021 22:20, Brandon Lo:
> On Thu, Jul 22, 2021 at 3:08 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 22/07/2021 21:06, Thomas Monjalon:
> > > 22/07/2021 11:17, Akhil Goyal:
> > > > > Enabled build of Octeontx crypto PMD on non linux OS. Other Octeontx
> > > > > PMDs are enabled already.
> > > > >
> > > > > This is to avoid ABI test failure on an OS once we add dependency
> > > > > between a driver which is built to another which is not.
> > > >
> > > > Fixes: 8dc6c2f12ecf ("crypto/octeontx: add crypto adapter framework")
> > > > >
> > > >
> > > > Reported-by: David Marchand <david.marchand@redhat.com>
> > > >
> > > > > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> > > >
> > > > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > > >
> > > > Thomas/David: please pick this patch directly on main to fix build on CI for FreeBSD.
> > >
> > > Applied, thanks.
> >
> > Please could you re-test the ABI on FreeBSD
> > and re-enable in the CI if the test is passing?
> >
> > Thank you
>
> I ran a couple test runs on FreeBSD 13 to ensure that the patch
> compiles successfully, and I enabled reporting.
> FreeBSD 13 should start to appear in the ABI test results of newer
> tarballs with the patch.
Thanks a lot Brandon, well managed.
prev parent reply other threads:[~2021-07-22 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CO6PR18MB4484E8FF18760E91DD96AFE9D8E49@CO6PR18MB4484.namprd18.prod.outlook.com>
[not found] ` <CO6PR18MB4484AED5BD861E05C8B1CC3BD8E49@CO6PR18MB4484.namprd18.prod.outlook.com>
[not found] ` <1815797.mnHlnkzLNo@thomas>
2021-07-22 19:08 ` Thomas Monjalon
2021-07-22 20:20 ` Brandon Lo
2021-07-22 20:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6211865.m4nO5kPP42@thomas \
--to=thomas@monjalon.net \
--cc=aconole@redhat.com \
--cc=blo@iol.unh.edu \
--cc=ci@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dpdklab@iol.unh.edu \
--cc=gakhil@marvell.com \
--cc=lylavoie@iol.unh.edu \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).