From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Declan Doherty <declan.doherty@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bond: vlan flags misinterpreted in xmit_slave_hash function
Date: Tue, 16 Dec 2014 12:22:36 +0100 [thread overview]
Message-ID: <6278160.abDBhLteg6@xps13> (raw)
In-Reply-To: <1418728549-31244-1-git-send-email-declan.doherty@intel.com>
Hi Declan,
2014-12-16 11:15, Declan Doherty:
> - Split transmit hashing function into separate functions to reduce branching
> and to make code clearer.
> - Add IPv4 IHL parameters to rte_ip.h
> - Fixed VLAN tag support in hashing functions and add support for TCP
> in layer 4 header hashing.
> - Fixed incorrect flag set in test application packet generator.
You forgot to describe the problem you are solving.
You seem fixing something but I'm afraid this patch is too big to be safely
integrated in 1.8.0.
Was it your goal?
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> ---
> app/test/packet_burst_generator.c | 2 +-
> lib/librte_net/rte_ip.h | 2 +
> lib/librte_pmd_bond/rte_eth_bond_api.c | 8 ++
> lib/librte_pmd_bond/rte_eth_bond_pmd.c | 161 ++++++++++++++++-------------
> lib/librte_pmd_bond/rte_eth_bond_private.h | 15 +++
> 5 files changed, 115 insertions(+), 73 deletions(-)
>
[...]
> --- a/lib/librte_net/rte_ip.h
> +++ b/lib/librte_net/rte_ip.h
> @@ -109,6 +109,8 @@ struct ipv4_hdr {
> (((b) & 0xff) << 16) | \
> (((c) & 0xff) << 8) | \
> ((d) & 0xff))
> +#define IPV4_HDR_IHL_MASK (0x0f)
> +#define IPV4_FIELD_WIDTH (4)
These new definitions require some doxygen comments.
Thanks
--
Thomas
next prev parent reply other threads:[~2014-12-16 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 11:15 Declan Doherty
2014-12-16 11:22 ` Thomas Monjalon [this message]
2014-12-16 11:44 ` Wodkowski, PawelX
2014-12-16 12:45 ` [dpdk-dev] [PATCH v2] " Declan Doherty
2015-01-07 2:50 ` Jiajia, SunX
2015-01-15 13:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6278160.abDBhLteg6@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).