From: "Wiles, Keith" <keith.wiles@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration information
Date: Fri, 4 Mar 2016 14:12:52 +0000 [thread overview]
Message-ID: <627CDDCB-D5C1-450D-BC81-79C89EB9F185@intel.com> (raw)
In-Reply-To: <56D95F88.2000708@redhat.com>
>On 03/03/2016 08:37 PM, Thomas Monjalon wrote:
>>> --- a/config/defconfig_x86_64-native-bsdapp-clang
>>> +++ b/config/defconfig_x86_64-native-bsdapp-clang
>>> @@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native"
>>> CONFIG_RTE_ARCH="x86_64"
>>> CONFIG_RTE_ARCH_X86_64=y
>>> CONFIG_RTE_ARCH_X86=y
>>> +CONFIG_RTE_ARCH_64=y
>>>
>>> CONFIG_RTE_TOOLCHAIN="clang"
>>> CONFIG_RTE_TOOLCHAIN_CLANG=y
>>> diff --git a/config/defconfig_x86_64-native-bsdapp-gcc b/config/defconfig_x86_64-native-bsdapp-gcc
>>> index 5a6a4e8..4ea4433 100644
>>> --- a/config/defconfig_x86_64-native-bsdapp-gcc
>>> +++ b/config/defconfig_x86_64-native-bsdapp-gcc
>>> @@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native"
>>> CONFIG_RTE_ARCH="x86_64"
>>> CONFIG_RTE_ARCH_X86_64=y
>>> CONFIG_RTE_ARCH_X86=y
>>> +CONFIG_RTE_ARCH_64=y
>>
>> It should be a totally separate patch.
>> And there are other places where it is missing.
>
>On a related note, perhaps the arch settings should be split to their
>own files, eg common_x86_64, common_i686 and so on that the defconfig
>files then include. That should eliminate things like missing
>CONFIG_RTE_ARCH_64 fairly effectively, and further reduce the
>duplication in the configs.
>
>I can send a patch to do that once the dust from the common_base move
>settles if you like the idea.
+1, Sounds reasonable to me.
>
> - Panu -
>
Regards,
Keith
next prev parent reply other threads:[~2016-03-04 14:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 13:53 Keith Wiles
2016-02-22 15:09 ` Trahe, Fiona
2016-02-22 16:02 ` Wiles, Keith
2016-02-22 16:44 ` Panu Matilainen
2016-02-24 13:58 ` Wiles, Keith
2016-02-24 14:19 ` Trahe, Fiona
2016-02-24 15:25 ` Wiles, Keith
2016-03-03 14:43 ` Wiles, Keith
2016-03-03 17:05 ` Thomas Monjalon
2016-03-03 18:37 ` Thomas Monjalon
2016-03-03 18:47 ` Wiles, Keith
2016-03-04 14:44 ` Wiles, Keith
2016-03-04 15:26 ` Thomas Monjalon
2016-03-04 9:28 ` Traynor, Kevin
2016-03-04 9:39 ` Panu Matilainen
2016-03-04 9:58 ` Traynor, Kevin
2016-03-04 10:28 ` Thomas Monjalon
2016-03-04 14:11 ` Wiles, Keith
2016-03-04 9:35 ` Panu Matilainen
2016-03-04 10:12 ` Panu Matilainen
2016-03-04 14:12 ` Wiles, Keith [this message]
2016-03-04 17:01 ` [dpdk-dev] [PATCH v2] " Keith Wiles
2016-03-04 17:26 ` Thomas Monjalon
2016-03-04 18:07 ` Wiles, Keith
2016-03-04 18:11 ` [dpdk-dev] [PATCH v3] " Keith Wiles
2016-03-04 22:43 ` Thomas Monjalon
2016-03-06 1:11 ` Ferruh Yigit
2016-03-06 1:21 ` [dpdk-dev] [PATCH] config: move Linux only config options from base to Linux config Ferruh Yigit
2016-03-06 9:35 ` [dpdk-dev] [PATCH v3] config: remove duplicate configuration information Thomas Monjalon
2016-03-07 12:41 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=627CDDCB-D5C1-450D-BC81-79C89EB9F185@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).