From: Thomas Monjalon <thomas@monjalon.net>
To: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples: remove unnecessary function calls
Date: Mon, 15 Jan 2018 12:14:36 +0100 [thread overview]
Message-ID: <6297491.ryl7qXoRam@xps> (raw)
In-Reply-To: <8ac37bf5-0fa7-ebb9-6b56-1247ed972e0b@intel.com>
11/12/2017 19:12, Ferruh Yigit:
> On 12/10/2017 11:31 PM, Prashant Bhole wrote:
> > Removed rte_eth_dev_info_get() calls and declaration of struct rte_eth_dev_info
> > where info is not used anymore
> >
> > Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> At any point in the history were they used? If so, can you please add the commit
> making them unnecessary with "Fixes" tag?
Maybe some were used. The first one I've checked was never used.
Not worth spending time on it in my opinion.
Applied, thanks
next prev parent reply other threads:[~2018-01-15 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 7:31 Prashant Bhole
2017-12-11 18:12 ` Ferruh Yigit
2018-01-15 11:14 ` Thomas Monjalon [this message]
2017-12-12 1:00 Prashant Bhole
2018-01-15 11:11 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6297491.ryl7qXoRam@xps \
--to=thomas@monjalon.net \
--cc=bhole_prashant_q7@lab.ntt.co.jp \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).