test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: "ohilyard@iol.unh.edu" <ohilyard@iol.unh.edu>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "lijuan.tu@intel.com" <lijuan.tu@intel.com>
Subject: RE: [PATCH v2 2/2] update files depending on tests/util
Date: Wed, 13 Apr 2022 07:28:04 +0000	[thread overview]
Message-ID: <62c2c46af37445c7b216cf1972d1cb20@pantheon.tech> (raw)
In-Reply-To: <20220411175549.14680-2-ohilyard@iol.unh.edu>

> diff --git a/framework/dut.py b/framework/dut.py index a2a93734..d6b8d34a
> 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -46,7 +46,7 @@ from .settings import LOG_NAME_SEP, NICS  from
> .ssh_connection import SSHConnection  from .test_result import ResultTable
> from .utils import RED, remove_old_rsa_key -from .virt_resource import
> VirtResource
> +from framework.virt_resource import VirtResource
> 

A minor point, this is an unneccesary change that violates the current convention. Is this a result of automated tools?


  parent reply	other threads:[~2022-04-13  7:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 17:55 [PATCH v2 1/2] framework: Move test-specific files to test directory ohilyard
2022-04-11 17:55 ` [PATCH v2 2/2] update files depending on tests/util ohilyard
2022-04-11 17:57   ` Owen Hilyard
2022-04-13  7:28   ` Juraj Linkeš [this message]
2022-04-13 12:50     ` Owen Hilyard
2022-04-13  7:25 ` [PATCH v2 1/2] framework: Move test-specific files to test directory Juraj Linkeš
2022-04-13 12:50   ` Owen Hilyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62c2c46af37445c7b216cf1972d1cb20@pantheon.tech \
    --to=juraj.linkes@pantheon.tech \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=ohilyard@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).