From: Remy Horton <remy.horton@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix multi-process NULL dereference crashes
Date: Wed, 25 Jan 2017 12:13:14 +0000 [thread overview]
Message-ID: <62d6a8d5-5a21-cdd8-6a7a-d81bef102313@intel.com> (raw)
In-Reply-To: <1844096.VBZFUxdXJL@xps13>
On 25/01/2017 11:56, Thomas Monjalon wrote:
[..]
> It does not describe exactly the use-case it is fixing (same in commit message).
> I guess you saw an issue when creating a vdev in the primary process and
> another one in a secondary process, erasing the data of the first one.
In my use-case the secondary process is proc_info, which appeared to be
blanking the shared memory then leaving the NULL-pointer landmines for
the primary process to land on. I'm not entirely sure why this type of
secondary process needs to be running any ethdev startup code at all, as
all it is doing is pulling data out of shared memory..
> My previous proposal was:
> memset(eth_dev->data, 0, sizeof(*eth_dev->data))
> It is better to avoid reference to the global array rte_eth_dev_data.
Git rebase screwed up, and it got lost en-route :(
..Remy
next prev parent reply other threads:[~2017-01-25 12:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 18:42 [dpdk-dev] [PATCH v1] " Remy Horton
2017-01-11 14:22 ` Thomas Monjalon
2017-01-11 15:01 ` Remy Horton
2017-01-20 18:37 ` Thomas Monjalon
2017-01-24 8:16 ` Remy Horton
2017-01-24 10:49 ` Thomas Monjalon
2017-01-24 11:03 ` Remy Horton
2017-01-24 15:01 ` [dpdk-dev] [PATCH v2] " Remy Horton
2017-01-25 11:56 ` Thomas Monjalon
2017-01-25 12:13 ` Remy Horton [this message]
2017-01-25 14:02 ` Remy Horton
2017-01-25 14:31 ` Thomas Monjalon
2017-01-25 14:38 ` Remy Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62d6a8d5-5a21-cdd8-6a7a-d81bef102313@intel.com \
--to=remy.horton@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).