From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: "Wiles, Keith" <keith.wiles@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/4] Introducing SPDX License Identifiers
Date: Fri, 15 Dec 2017 16:22:31 +0530 [thread overview]
Message-ID: <63001fe4-2b0e-0f4d-60c2-e94201f13e9f@nxp.com> (raw)
In-Reply-To: <9A962A20-EFFC-45AD-ABD7-CC888080C4A9@intel.com>
Thanks for all the comments. I will rework and post.
Also, my bad for flip-flop but I have to agree with Stephen's suggestion
to adapt Linux style. i.e. use SPDX tag in top line or 2nd line for scripts.
This is for following reason:
1. DPDK will be using kernel tools such as checkpatch.
2. DPDK has common driver code between kernel and dpdk. It will be easy
for contributors.
Quoting from the Red's patch (https://patchwork.kernel.org/patch/10053699/)
=>SPDX license tags are a thing now in the kernel[1]. It has also been
decided to make them the first line in files. As Linus put it:
"The real reason _I_ personally would like to see at least all the new
SPDX lines to go at the very top of the file is that every time when
we have some kind of ambiguity about placement, we end up with
multiple cases, and then people don't notice when merging, and you end
up having two - or you just end up having unnecessary merge conflicts
because two different people picked two different choices)."
regards,
Hemant
next prev parent reply other threads:[~2017-12-15 10:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 7:46 [dpdk-dev] [PATCH 1/2] " Hemant Agrawal
2017-11-27 7:46 ` [dpdk-dev] [PATCH 2/2] Change root makefile license to SPDX tag Hemant Agrawal
2017-11-27 12:01 ` Bruce Richardson
2017-12-01 8:41 ` Hemant Agrawal
2017-11-28 16:59 ` [dpdk-dev] [PATCH 1/2] Introducing SPDX License Identifiers Stephen Hemminger
2017-12-01 8:38 ` [dpdk-dev] [PATCH v2 " Hemant Agrawal
2017-12-01 8:38 ` [dpdk-dev] [PATCH v2 2/2] Change root makefile license to SPDX tag Hemant Agrawal
2017-12-07 23:46 ` [dpdk-dev] [PATCH v2 1/2] Introducing SPDX License Identifiers Ferruh Yigit
2017-12-08 4:57 ` Hemant Agrawal
2017-12-08 7:41 ` [dpdk-dev] [PATCH v3 1/4] " Hemant Agrawal
2017-12-08 7:41 ` [dpdk-dev] [PATCH v3 2/4] change root makefile license to SPDX tag Hemant Agrawal
2017-12-08 7:41 ` [dpdk-dev] [PATCH v3 3/4] change NXP dpaa2 code License text to SPDX tags Hemant Agrawal
2017-12-08 18:07 ` Stephen Hemminger
2017-12-08 7:41 ` [dpdk-dev] [PATCH v3 4/4] change NXP dpaa " Hemant Agrawal
2017-12-13 10:46 ` [dpdk-dev] [PATCH v3 1/4] Introducing SPDX License Identifiers Thomas Monjalon
2017-12-13 11:38 ` Bruce Richardson
2017-12-13 15:38 ` Wiles, Keith
2017-12-15 10:52 ` Hemant Agrawal [this message]
2017-12-18 12:39 ` [dpdk-dev] [PATCH v4 " Hemant Agrawal
2017-12-18 12:39 ` [dpdk-dev] [PATCH v4 2/4] change root makefile license to SPDX tag Hemant Agrawal
2017-12-18 14:32 ` Bruce Richardson
2017-12-18 15:52 ` Bruce Richardson
2017-12-18 16:30 ` Thomas Monjalon
2017-12-19 5:29 ` Hemant Agrawal
2017-12-19 10:01 ` Bruce Richardson
2017-12-18 12:39 ` [dpdk-dev] [PATCH v4 3/4] change NXP dpaa2 code License text to SPDX tags Hemant Agrawal
2017-12-18 12:39 ` [dpdk-dev] [PATCH v4 4/4] change NXP dpaa " Hemant Agrawal
2017-12-19 10:14 ` [dpdk-dev] [PATCH v5 1/4] Introducing SPDX License Identifiers Hemant Agrawal
2017-12-19 10:14 ` [dpdk-dev] [PATCH v5 2/4] change root makefile license to SPDX tag Hemant Agrawal
2017-12-19 10:23 ` Bruce Richardson
2017-12-19 10:14 ` [dpdk-dev] [PATCH v5 3/4] change NXP dpaa2 code License text to SPDX tags Hemant Agrawal
2017-12-19 10:14 ` [dpdk-dev] [PATCH v5 4/4] change NXP dpaa " Hemant Agrawal
2018-01-04 18:32 ` [dpdk-dev] [PATCH v5 1/4] Introducing SPDX License Identifiers Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63001fe4-2b0e-0f4d-60c2-e94201f13e9f@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=keith.wiles@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).