From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hernan Vargas <hernan.vargas@intel.com>,
dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com
Subject: Re: [PATCH v3 5/7] baseband/acc: acc100 use define constant
Date: Tue, 17 Jan 2023 11:50:05 +0100 [thread overview]
Message-ID: <63168ad5-add1-d718-2305-801f736befa6@redhat.com> (raw)
In-Reply-To: <20230112193609.273578-6-hernan.vargas@intel.com>
On 1/12/23 20:36, Hernan Vargas wrote:
> Use define constant ACC_HARQ_ALIGN_64B instead of hardcoded number.
> No functional impact.
>
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
> drivers/baseband/acc/rte_acc100_pmd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
> index 3660d3b240..ef1c488a1c 100644
> --- a/drivers/baseband/acc/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc/rte_acc100_pmd.c
> @@ -1390,7 +1390,7 @@ acc101_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw,
> harq_in_length = RTE_MIN(harq_in_length, op->ldpc_dec.n_cb
> - op->ldpc_dec.n_filler);
> /* Alignment on next 64B - Already enforced from HC output */
> - harq_in_length = RTE_ALIGN_FLOOR(harq_in_length, 64);
> + harq_in_length = RTE_ALIGN_FLOOR(harq_in_length, ACC_HARQ_ALIGN_64B);
> fcw->hcin_size0 = harq_in_length;
> fcw->hcin_offset = 0;
> fcw->hcin_size1 = 0;
> @@ -1433,7 +1433,7 @@ acc101_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw,
> /* Cannot exceed the pruned Ncb circular buffer */
> harq_out_length = RTE_MIN(harq_out_length, ncb_p);
> /* Alignment on next 64B */
> - harq_out_length = RTE_ALIGN_CEIL(harq_out_length, 64);
> + harq_out_length = RTE_ALIGN_CEIL(harq_out_length, ACC_HARQ_ALIGN_64B);
> fcw->hcout_size0 = harq_out_length;
> fcw->hcout_size1 = 0;
> fcw->hcout_offset = 0;
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2023-01-17 10:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 19:36 [PATCH v3 0/7] baseband/acc: changes for 23.03 Hernan Vargas
2023-01-12 19:36 ` [PATCH v3 1/7] baseband/acc: acc100 free harq layout pointer Hernan Vargas
2023-01-17 10:49 ` Maxime Coquelin
2023-01-12 19:36 ` [PATCH v3 2/7] baseband/acc: acc100 fix iteration counter in TB Hernan Vargas
2023-01-17 10:49 ` Maxime Coquelin
2023-01-12 19:36 ` [PATCH v3 3/7] baseband/acc: acc100 fix multiplexing multiple ops Hernan Vargas
2023-01-17 10:49 ` Maxime Coquelin
2023-01-12 19:36 ` [PATCH v3 4/7] baseband/acc: acc100 fix queue mapping to 64 bits Hernan Vargas
2023-01-17 10:49 ` Maxime Coquelin
2023-01-12 19:36 ` [PATCH v3 5/7] baseband/acc: acc100 use define constant Hernan Vargas
2023-01-17 10:50 ` Maxime Coquelin [this message]
2023-01-12 19:36 ` [PATCH v3 6/7] baseband/acc: acc100 use desc helper functions Hernan Vargas
2023-01-17 10:50 ` Maxime Coquelin
2023-01-12 19:36 ` [PATCH v3 7/7] baseband/acc: acc100 ignore missing mempools Hernan Vargas
2023-01-17 10:50 ` Maxime Coquelin
2023-01-17 10:49 ` [PATCH v3 0/7] baseband/acc: changes for 23.03 Maxime Coquelin
2023-01-19 10:06 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63168ad5-add1-d718-2305-801f736befa6@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).