From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/2] introduce dev_ops to get extended statistics of a device
Date: Tue, 23 Sep 2014 17:49:22 +0200 [thread overview]
Message-ID: <6332355.DEeBjUGxto@xps13> (raw)
In-Reply-To: <59AF69C657FD0841A61C55336867B5B0343B1737@IRSMSX103.ger.corp.intel.com>
2014-07-23 18:41, Richardson, Bruce:
> > The generic statistics structure is getting bigger as new statistics are
> > added in specific devices. For instance, fdir, tx_pause or loopback
> > stats do not apply on virtual devices. It won't be possible to add every
> > specific statistics in this generic stats structure, but on the other
> > hand these specific statistics are useful for debugging purpose.
> >
> > This 2 patches introduces xstats_get() and xstats_reset() in
> > dev_ops. When registered by a device, it can be used to provide
> > arbitrary statistics that are identified by a name, as done by eththool
> > in kernel.
> >
> > After that, some statistics could be moved from the generic structure to
> > this new framework, but it will be part of another patch series as it
> > should be discussed first.
>
> I like the idea, so Ack on the concept. :-)
Applied with some minor fixes in the comments.
Next step is to move some fields from rte_eth_stats to extended stats.
First candidates to move are the VF-only counters.
Thanks
--
Thomas
prev parent reply other threads:[~2014-09-23 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 12:28 Olivier Matz
2014-07-23 12:28 ` [dpdk-dev] [PATCH 1/2] ethdev: add a new rte_eth_xstats_get method to retrieve extended statistics Olivier Matz
2014-07-23 12:28 ` [dpdk-dev] [PATCH 2/2] testpmd: add a new command to get the extended statistics of a port Olivier Matz
2014-07-23 18:41 ` [dpdk-dev] [PATCH 0/2] introduce dev_ops to get extended statistics of a device Richardson, Bruce
2014-09-23 15:49 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6332355.DEeBjUGxto@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).