From: Sinan Kaya <okaya@kernel.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [PATCH RESEND v2 01/11] ethdev: check return result of rte_eth_dev_info_get
Date: Thu, 19 Jan 2023 00:22:31 -0500 [thread overview]
Message-ID: <635a6e3bcabf6ced16eb87cd8544a11c0a576a73.camel@kernel.org> (raw)
In-Reply-To: <2581232.ECZNHGQPT7@thomas>
On Wed, 2023-01-18 at 09:42 +0100, Thomas Monjalon wrote:
> 22/11/2022 16:30,
> okaya@kernel.org
> :
>
> > rte_class_eth: eth_mac_cmp: The status of this call to
> > rte_eth_dev_info_get
> > is not checked, potentially leaving dev_info uninitialized.
>
> [...]
>
> > /* Return 0 if devargs MAC is matching one of the device
> > MACs. */
> > - rte_eth_dev_info_get(data->port_id, &dev_info);
> > + if (rte_eth_dev_info_get(data->port_id, &dev_info) < 0)
> > + return -1;
> > +
> > for (index = 0; index < dev_info.max_mac_addrs; index++)
> > if (rte_is_same_ether_addr(&mac, &data-
> > >mac_addrs[index]))
> > return 0;
>
>
>
> Acked-by: Thomas Monjalon <
> thomas@monjalon.net
> >
>
>
Thanks.
>
> You would get more attention if you Cc the maintainers.
>
> You can use this git option: --cc-cmd devtools/get-maintainer.sh
Good to know that we have get-maintainer script.
next prev parent reply other threads:[~2023-01-19 5:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 15:30 [PATCH RESEND v2 00/11] codeql fixes for various subsystems okaya
2022-11-22 15:30 ` [PATCH RESEND v2 01/11] ethdev: check return result of rte_eth_dev_info_get okaya
2023-01-18 8:42 ` Thomas Monjalon
2023-01-19 5:22 ` Sinan Kaya [this message]
2023-01-19 14:20 ` Ferruh Yigit
2022-11-22 15:30 ` [PATCH RESEND v2 02/11] net/tap: check if name is null okaya
2023-01-18 10:57 ` Ferruh Yigit
2023-01-19 5:21 ` Sinan Kaya
2022-11-22 15:30 ` [PATCH RESEND v2 03/11] memzone: check result of rte_fbarray_get okaya
2022-11-22 15:30 ` [PATCH RESEND v2 04/11] memzone: check result of malloc_elem_from_data okaya
2022-11-22 15:30 ` [PATCH RESEND v2 05/11] malloc: malloc_elem_join_adjacent_free can return null okaya
2022-11-22 15:30 ` [PATCH RESEND v2 06/11] malloc: check result of rte_mem_virt2memseg_list okaya
2022-11-22 15:30 ` [PATCH RESEND v2 07/11] malloc: check result of rte_fbarray_get okaya
2022-11-22 15:30 ` [PATCH RESEND v2 08/11] malloc: check result of rte_mem_virt2memseg okaya
2022-11-22 15:30 ` [PATCH RESEND v2 09/11] malloc: check result of malloc_elem_free okaya
2022-11-22 15:30 ` [PATCH RESEND v2 10/11] malloc: check result of elem_start_pt okaya
2022-11-22 15:30 ` [PATCH RESEND v2 11/11] bus/vdev: check result of rte_vdev_device_name okaya
2022-12-13 16:43 ` [PATCH RESEND v2 00/11] codeql fixes for various subsystems Sinan Kaya
2022-12-13 16:59 ` Dmitry Kozlyuk
2022-12-13 17:02 ` Sinan Kaya
2022-12-16 15:26 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=635a6e3bcabf6ced16eb87cd8544a11c0a576a73.camel@kernel.org \
--to=okaya@kernel.org \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).