From: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
To: gazmarsh@meaningfulname.net
Cc: dev@dpdk.org, konstantin.v.ananyev@yandex.ru,
vladimir.medvedkin@intel.com
Subject: Re: [PATCH] ipsec: use sym_session_opaque_data for RTE_SECURITY_TYPE_CPU_CRYPTO
Date: Tue, 31 Oct 2023 01:08:57 +0000 [thread overview]
Message-ID: <64c6794e-69ef-4469-a596-32cd9d70d0bd@yandex.ru> (raw)
In-Reply-To: <20230925201128.861-1-gazmarsh@meaningfulname.net>
>
>
> ipsec related processing in dpdk makes use of the crypto.ses opaque
> data pointer. This patch updates rte_ipsec_session_prepare to set
> ss->crypto.ses in the RTE_SECURITY_TYPE_CPU_CRYPTO case.
Hmm.. not sure why we need to do that for CPU_CRYPTO?
As I remember CPU_CRYPTO is synchronous operation and before calling
rte_ipsec_pkt_cpu_prepare() should already know ipsec session these
packets belong to.
Can you probably explain the logic behind this patch a bit more?
Konstantin
>
> Signed-off-by: Garry Marshall <gazmarsh@meaningfulname.net>
> ---
> lib/ipsec/ses.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/ipsec/ses.c b/lib/ipsec/ses.c
> index d9ab1e6d2b..29eb5ff6ca 100644
> --- a/lib/ipsec/ses.c
> +++ b/lib/ipsec/ses.c
> @@ -44,7 +44,8 @@ rte_ipsec_session_prepare(struct rte_ipsec_session *ss)
>
> ss->pkt_func = fp;
>
> - if (ss->type == RTE_SECURITY_ACTION_TYPE_NONE)
> + if (ss->type == RTE_SECURITY_ACTION_TYPE_NONE ||
> + ss->type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO)
> rte_cryptodev_sym_session_opaque_data_set(ss->crypto.ses,
> (uintptr_t)ss);
> else
> --
> 2.39.2
next prev parent reply other threads:[~2023-10-31 1:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 20:11 Garry Marshall
2023-10-30 7:22 ` [EXT] " Akhil Goyal
2023-10-31 1:08 ` Konstantin Ananyev [this message]
2023-10-31 9:36 ` Garry Marshall
2023-10-31 17:53 ` Konstantin Ananyev
2023-11-02 7:20 ` Garry Marshall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64c6794e-69ef-4469-a596-32cd9d70d0bd@yandex.ru \
--to=konstantin.v.ananyev@yandex.ru \
--cc=dev@dpdk.org \
--cc=gazmarsh@meaningfulname.net \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).