From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, <dev@dpdk.org>
Cc: <pablo.de.lara.guarch@intel.com>, <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] crypto/dpaa2_sec: fix HMAC supported key sizes
Date: Thu, 27 Jul 2017 19:27:46 +0530 [thread overview]
Message-ID: <6520377e-bf24-a340-85b4-620b66d91fe9@nxp.com> (raw)
In-Reply-To: <20170727115408.20386-1-akhil.goyal@nxp.com>
On 7/27/2017 5:24 PM, Akhil Goyal wrote:
> For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
> key sizes are not a fixed value, but a range between
> 1 and the block size.
>
> Fixes: 623326dded3a ("crypto/dpaa2_sec: introduce poll mode driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
> drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> index e104f71..3849a05 100644
> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> @@ -200,9 +200,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
> .algo = RTE_CRYPTO_AUTH_MD5_HMAC,
> .block_size = 64,
> .key_size = {
> - .min = 64,
> + .min = 1,
> .max = 64,
> - .increment = 0
> + .increment = 1
> },
> .digest_size = {
> .min = 16,
> @@ -221,9 +221,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
> .algo = RTE_CRYPTO_AUTH_SHA1_HMAC,
> .block_size = 64,
> .key_size = {
> - .min = 64,
> + .min = 1,
> .max = 64,
> - .increment = 0
> + .increment = 1
> },
> .digest_size = {
> .min = 20,
> @@ -242,9 +242,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
> .algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
> .block_size = 64,
> .key_size = {
> - .min = 64,
> + .min = 1,
> .max = 64,
> - .increment = 0
> + .increment = 1
> },
> .digest_size = {
> .min = 28,
> @@ -263,9 +263,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
> .algo = RTE_CRYPTO_AUTH_SHA256_HMAC,
> .block_size = 64,
> .key_size = {
> - .min = 64,
> + .min = 1,
> .max = 64,
> - .increment = 0
> + .increment = 1
> },
> .digest_size = {
> .min = 32,
> @@ -284,9 +284,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
> .algo = RTE_CRYPTO_AUTH_SHA384_HMAC,
> .block_size = 128,
> .key_size = {
> - .min = 128,
> + .min = 1,
> .max = 128,
> - .increment = 0
> + .increment = 1
> },
> .digest_size = {
> .min = 48,
> @@ -305,9 +305,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
> .algo = RTE_CRYPTO_AUTH_SHA512_HMAC,
> .block_size = 128,
> .key_size = {
> - .min = 128,
> + .min = 1,
> .max = 128,
> - .increment = 0
> + .increment = 1
> },
> .digest_size = {
> .min = 64,
>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
next prev parent reply other threads:[~2017-07-27 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170725052457.43952-1-pablo.de.lara.guarch@intel.com>
2017-07-25 5:24 ` [dpdk-stable] [PATCH 1/3] crypto/aesni_mb: " Pablo de Lara
2017-07-27 10:22 ` Declan Doherty
2017-07-25 5:24 ` [dpdk-stable] [PATCH 2/3] crypto/openssl: " Pablo de Lara
2017-07-27 10:21 ` Declan Doherty
2017-07-25 5:24 ` [dpdk-stable] [PATCH 3/3] crypto/qat: " Pablo de Lara
2017-07-27 9:54 ` Trahe, Fiona
2017-07-27 11:54 ` [dpdk-stable] [PATCH] crypto/dpaa2_sec: " Akhil Goyal
2017-07-27 13:57 ` Hemant Agrawal [this message]
2017-07-27 14:25 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6520377e-bf24-a340-85b4-620b66d91fe9@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).