From: Thomas Monjalon <thomas@monjalon.net>
To: Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] doc: add new targets to "make help" output
Date: Sat, 05 Aug 2017 11:08:58 +0200 [thread overview]
Message-ID: <65331094.Yj0jldVl8I@xps> (raw)
In-Reply-To: <2383964.bQBCqqHOqo@xps>
04/08/2017 00:50, Thomas Monjalon:
> Hi,
>
> Sorry for the very very late review.
>
> 07/07/2017 19:09, Gabriel Carrillo:
> > Commit aafaea3d3b70 ("devtools: add tags
> > and cscope index generation") introduced
> > new make targets. This change updates the
> > help target output to reflect the additions.
> >
> > Signed-off-by: Gabriel Carrillo <erik.g.carrillo@intel.com>
> > ---
> > + tags|gtags T= generate tags/gtags for given targets (T=)
> > + cscope T= generate cscope database for given targets (T=)
>
> No need of T= in the first column.
> It is specified only for install which has two different meanings
> with and without T=.
>
> You should also add etags I think.
Updated myself and applied, thanks
prev parent reply other threads:[~2017-08-05 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 21:43 [dpdk-dev] [PATCH] " Gabriel Carrillo
2017-06-06 6:40 ` Thomas Monjalon
2017-06-06 16:42 ` [dpdk-dev] [PATCH v2] " Gabriel Carrillo
2017-06-26 15:38 ` Mcnamara, John
2017-07-07 17:00 ` Carrillo, Erik G
2017-07-07 17:09 ` [dpdk-dev] [PATCH v3] " Gabriel Carrillo
2017-08-03 22:50 ` Thomas Monjalon
2017-08-05 9:08 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65331094.Yj0jldVl8I@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).