From: Remy Horton <remy.horton@intel.com>
To: David Marchand <david.marchand@6wind.com>, dev@dpdk.org
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com,
bernard.iremonger@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] app/testpmd: add sanity checks when retrieving xstats
Date: Tue, 12 Jun 2018 09:38:27 +0100 [thread overview]
Message-ID: <660a5233-0e54-3028-3a86-1ad167f4e937@intel.com> (raw)
In-Reply-To: <1528359323-22885-1-git-send-email-david.marchand@6wind.com>
Was out of office, so only saw the patchset this morning.
Missing fixlines (watch out for subject line wrap):
Fixes: e2aae1c1ced9 ("ethdev: remove name from extended statistic fetch")
Fixes: 0a5beecf466a ("ethdev: revert xstats by ID")
Otherwise looks good to me. A case of implementation simplification
turning into API assumption :(
..Remy
On 07/06/2018 09:15, David Marchand wrote:
[..]
> Signed-off-by: David Marchand <david.marchand@6wind.com>
Acked-by: Remy Horton <remy.horton@intel.com>
next prev parent reply other threads:[~2018-06-12 8:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 8:15 David Marchand
2018-06-12 7:09 ` David Marchand
2018-06-12 8:38 ` Remy Horton [this message]
2018-06-13 15:39 ` Ferruh Yigit
2018-06-14 6:39 ` Remy Horton
2018-06-14 10:55 ` Ferruh Yigit
2018-06-14 19:33 ` Remy Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=660a5233-0e54-3028-3a86-1ad167f4e937@intel.com \
--to=remy.horton@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).