From: Gaetan Rivet <gaetan.rivet@6wind.com>
To: dev@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>, stable@dpdk.org
Subject: [dpdk-stable] [PATCH 6/9] pci: fix generic driver pointer on probe error
Date: Sun, 9 Jul 2017 03:45:42 +0200 [thread overview]
Message-ID: <66edddf78fe0b6e1f156014f1e5c3c07bef209ad.1499563730.git.gaetan.rivet@6wind.com> (raw)
In-Reply-To: <cover.1499563730.git.gaetan.rivet@6wind.com>
In-Reply-To: <cover.1499563730.git.gaetan.rivet@6wind.com>
The field is set but never resetted on error.
This marks the device as being attached while it is not, and forbid
further attempts to hotplug it.
Fixes: 7917d5f5ea46 ("pci: initialize generic driver pointer")
Cc: stable@dpdk.org
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
lib/librte_eal/common/eal_common_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
index b100525..9cc4148 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -237,6 +237,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
ret = dr->probe(dr, dev);
if (ret) {
dev->driver = NULL;
+ dev->device.driver = NULL;
if ((dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) &&
/* Don't unmap if device is unsupported and
* driver needs mapped resources.
--
2.1.4
next prev parent reply other threads:[~2017-07-09 1:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1499563730.git.gaetan.rivet@6wind.com>
2017-07-09 1:45 ` [dpdk-stable] [PATCH 5/9] pci: use given name as generic name Gaetan Rivet
2017-07-09 1:45 ` Gaetan Rivet [this message]
[not found] ` <cover.1499728330.git.gaetan.rivet@6wind.com>
2017-07-10 23:19 ` [dpdk-stable] [PATCH v2 5/8] " Gaetan Rivet
2017-07-10 23:19 ` [dpdk-stable] [PATCH v2 6/8] pci: fix generic driver pointer on probe error Gaetan Rivet
[not found] ` <cover.1499814957.git.gaetan.rivet@6wind.com>
2017-07-11 23:25 ` [dpdk-stable] [PATCH v3 5/8] pci: use given name as generic name Gaetan Rivet
2017-07-11 23:25 ` [dpdk-stable] [PATCH v3 6/8] pci: fix generic driver pointer on probe error Gaetan Rivet
[not found] ` <cover.1499964391.git.gaetan.rivet@6wind.com>
2017-07-15 17:56 ` [dpdk-stable] [PATCH v4 5/8] pci: use given name as generic name Gaetan Rivet
2017-07-15 17:56 ` [dpdk-stable] [PATCH v4 6/8] pci: fix generic driver pointer on probe error Gaetan Rivet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66edddf78fe0b6e1f156014f1e5c3c07bef209ad.1499563730.git.gaetan.rivet@6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).