From: Thomas Monjalon <thomas@monjalon.net>
To: "Zhang, Fan" <fanzhang.oss@gmail.com>,
Jerin Jacob <jerinjacobk@gmail.com>
Cc: David Marchand <david.marchand@redhat.com>,
Volodymyr Fialko <vfialko@marvell.com>,
dev@dpdk.org, Jerin Jacob <jerinj@marvell.com>,
Akhil Goyal <gakhil@marvell.com>,
anoobj@marvell.com
Subject: Re: [PATCH] build: fix missing crypto vec limits in version
Date: Tue, 17 Jan 2023 22:10:47 +0100 [thread overview]
Message-ID: <6754457.tM3a2QDmDi@thomas> (raw)
In-Reply-To: <CALBAE1P473-x4OZ4A=ofSzmCFaaPJXaryaghPmODCvGc=6wwLg@mail.gmail.com>
17/01/2023 17:25, Jerin Jacob:
> On Tue, Dec 6, 2022 at 2:58 PM Zhang, Fan <fanzhang.oss@gmail.com> wrote:
> >
> > On 12/6/2022 9:23 AM, Volodymyr Fialko wrote:
> > > Add missing function `rte_event_crypto_adapter_vector_limits_get` to
> > > version.map.
> > >
> > > Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")
> > >
> > > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> > > ---
> > > lib/eventdev/version.map | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> > > index dd63ec6f68..1a7fffd17f 100644
> > > --- a/lib/eventdev/version.map
> > > +++ b/lib/eventdev/version.map
> > > @@ -20,6 +20,7 @@ DPDK_23 {
> > > rte_event_crypto_adapter_stats_get;
> > > rte_event_crypto_adapter_stats_reset;
> > > rte_event_crypto_adapter_stop;
> > > + rte_event_crypto_adapter_vector_limits_get;
> > > rte_event_dequeue_timeout_ticks;
> > > rte_event_dev_attr_get;
> > > rte_event_dev_close;
> > Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
>
> + @Thomas Monjalon @David Marchand
>
> 1) Sanity is failing as follows
> ### [PATCH] build: fix missing crypto vec limits in version
>
> ERROR: symbol rte_event_crypto_adapter_vector_limits_get is added in
> the DPDK_23 section, but is expected to be added in the EXPERIMENTAL
> section of the version map
>
> This patch is added in 22.07. New patches should be experimental.
> Right? If so, Please change to __rte_experimental and move
> EXPERIMENTAL section. If I am not missing anything.
Yes new functions should be experimental.
You need to add a comment in the .h
and the attribute __rte_experimental.
Such issue would have been seen earlier if the new function
was used in a unit test or a test application.
next prev parent reply other threads:[~2023-01-17 21:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 9:23 Volodymyr Fialko
2022-12-06 9:28 ` Zhang, Fan
2023-01-17 16:25 ` Jerin Jacob
2023-01-17 21:10 ` Thomas Monjalon [this message]
2023-01-18 10:21 ` [PATCH v2] eventdev/crypto: fix missing crypto vec limits Volodymyr Fialko
2023-01-23 9:35 ` Gujjar, Abhinandan S
2023-01-23 13:26 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6754457.tM3a2QDmDi@thomas \
--to=thomas@monjalon.net \
--cc=anoobj@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=vfialko@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).