From: Thomas Monjalon <thomas@monjalon.net>
To: Luca Boccassi <bluca@debian.org>
Cc: dev@dpdk.org, Tiwei Bie <tiwei.bie@intel.com>,
maxime.coquelin@redhat.com, zhihong.wang@intel.com,
bruce.richardson@intel.com, brian.russell@intl.att.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v6 2/2] net/virtio: fix PCI config err handling
Date: Mon, 29 Oct 2018 00:55:17 +0100 [thread overview]
Message-ID: <6822792.WN0bvDObni@xps> (raw)
In-Reply-To: <20181011130100.GA628@debian>
11/10/2018 15:01, Tiwei Bie:
> On Thu, Oct 11, 2018 at 11:53:12AM +0100, Luca Boccassi wrote:
> > On Thu, 2018-10-11 at 12:27 +0200, Thomas Monjalon wrote:
> > > 28/08/2018 12:12, Luca Boccassi:
> > > > From: Brian Russell <brussell@brocade.com>
> > > >
> > > > In virtio_read_caps and vtpci_msix_detect, rte_pci_read_config
> > > > returns
> > > > the number of bytes read from PCI config or < 0 on error.
> > > > If less than the expected number of bytes are read then log the
> > > > failure and return rather than carrying on with garbage.
> > > >
> > > > Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0")
> > > >
> > > > Signed-off-by: Brian Russell <brussell@brocade.com>
> > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > ---
> > > > v2: handle additional rte_pci_read_config incomplete reads
> > > > v3: do not handle rte_pci_read_config of virtio cap, added in v2,
> > > > as it's less clear what the right thing to do there is
> > > > v4: do a more robust check - first check what the vendor is, and
> > > > skip the cap entirely if it's not what we are looking for.
> > > > v5: fetch only 2 flags bytes if the vndr is PCI_CAP_ID_MSIX
> > > > v6: fix 32bit build by changing the printf format specifier, fix
> > > > patch title
> > >
> > > Tiwei did a comment on v5 and provided his Reviewed-by.
> > > Is it OK to apply v6 with its tag?
> > > All is fixed?
> >
> > Hi,
> >
> > The title has been fixed (virtio -> net/virtio) and I just tried a
> > 32bit build and it works fine after the fix from v6.
>
> Thanks Luca!
>
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Cc: stable@dpdk.org
Series applied, thanks
parent reply other threads:[~2018-10-28 23:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20181011130100.GA628@debian>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6822792.WN0bvDObni@xps \
--to=thomas@monjalon.net \
--cc=bluca@debian.org \
--cc=brian.russell@intl.att.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).